DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Guinan Sun <guinanx.sun@intel.com>
Cc: dev@dpdk.org, Beilei Xing <beilei.xing@intel.com>,
	Qi Zhang <qi.z.zhang@intel.com>,
	Qiming Yang <qiming.yang@intel.com>,
	stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix flow control broken
Date: Mon, 16 Dec 2019 13:22:49 +0800	[thread overview]
Message-ID: <20191216052249.GJ59123@intel.com> (raw)
In-Reply-To: <20191216050636.GH59123@intel.com>

On 12/16, Ye Xiaolong wrote:
>On 12/06, Guinan Sun wrote:
>>Repeat switching flow control on or off during receiving traffic,
>>testpmd reports "failed to switch Tx queue occurs" after quit.
>>The patch fixes the issue.
>>
>>Fixes: f53577f06925 ("i40e: support flow control")
>>Cc: stable@dpdk.org
>>
>>Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
>>---
>> drivers/net/i40e/i40e_ethdev.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
>>index 5999c964b..5507f6c39 100644
>>--- a/drivers/net/i40e/i40e_ethdev.c
>>+++ b/drivers/net/i40e/i40e_ethdev.c
>>@@ -53,7 +53,7 @@
>> 
>> /* Wait count and interval */
>> #define I40E_CHK_Q_ENA_COUNT       1000
>>-#define I40E_CHK_Q_ENA_INTERVAL_US 1000
>>+#define I40E_CHK_Q_ENA_INTERVAL_US 50000
>> 
>> /* Maximun number of VSI */
>> #define I40E_MAX_NUM_VSIS          (384UL)
>>-- 
>>2.17.1
>>
>
>Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>
>
>Applied to dpdk-next-net-intel, Thanks.

Sorry, there is still concern about this patch, drop it from next-net-intel first.

      reply	other threads:[~2019-12-16  5:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-06 15:41 Guinan Sun
2019-12-08 23:51 ` Zhang, Qi Z
2019-12-16  5:06 ` Ye Xiaolong
2019-12-16  5:22   ` Ye Xiaolong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191216052249.GJ59123@intel.com \
    --to=xiaolong.ye@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=guinanx.sun@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).