From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BECCDA04B3; Mon, 16 Dec 2019 06:27:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A7A6E1C08E; Mon, 16 Dec 2019 06:27:36 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 2CCDB1C08D; Mon, 16 Dec 2019 06:27:34 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Dec 2019 21:27:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,320,1571727600"; d="scan'208";a="204997404" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga007.jf.intel.com with ESMTP; 15 Dec 2019 21:27:31 -0800 Date: Mon, 16 Dec 2019 13:22:49 +0800 From: Ye Xiaolong To: Guinan Sun Cc: dev@dpdk.org, Beilei Xing , Qi Zhang , Qiming Yang , stable@dpdk.org Message-ID: <20191216052249.GJ59123@intel.com> References: <20191206154118.4401-1-guinanx.sun@intel.com> <20191216050636.GH59123@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191216050636.GH59123@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix flow control broken X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/16, Ye Xiaolong wrote: >On 12/06, Guinan Sun wrote: >>Repeat switching flow control on or off during receiving traffic, >>testpmd reports "failed to switch Tx queue occurs" after quit. >>The patch fixes the issue. >> >>Fixes: f53577f06925 ("i40e: support flow control") >>Cc: stable@dpdk.org >> >>Signed-off-by: Guinan Sun >>--- >> drivers/net/i40e/i40e_ethdev.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >>diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c >>index 5999c964b..5507f6c39 100644 >>--- a/drivers/net/i40e/i40e_ethdev.c >>+++ b/drivers/net/i40e/i40e_ethdev.c >>@@ -53,7 +53,7 @@ >> >> /* Wait count and interval */ >> #define I40E_CHK_Q_ENA_COUNT 1000 >>-#define I40E_CHK_Q_ENA_INTERVAL_US 1000 >>+#define I40E_CHK_Q_ENA_INTERVAL_US 50000 >> >> /* Maximun number of VSI */ >> #define I40E_MAX_NUM_VSIS (384UL) >>-- >>2.17.1 >> > >Acked-by: Xiaolong Ye > >Applied to dpdk-next-net-intel, Thanks. Sorry, there is still concern about this patch, drop it from next-net-intel first.