* [dpdk-dev] [PATCH] net/vhost: fix return value of vhost creates not checked
@ 2019-12-16 1:05 Yunjian Wang
2019-12-16 5:33 ` Tiwei Bie
0 siblings, 1 reply; 4+ messages in thread
From: Yunjian Wang @ 2019-12-16 1:05 UTC (permalink / raw)
To: dev
Cc: maxime.coquelin, tiwei.bie, zhihong.wang, xudingke, Yunjian Wang, stable
The function eth_dev_vhost_create() could return errors,
the return value need to be checked.
Fixes: ee584e9710b9 ("vhost: add driver on top of the library")
Cc: stable@dpdk.org
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
drivers/net/vhost/rte_eth_vhost.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
index 46f01a7..7e4faf2 100644
--- a/drivers/net/vhost/rte_eth_vhost.c
+++ b/drivers/net/vhost/rte_eth_vhost.c
@@ -1455,8 +1455,10 @@ struct vhost_xstats_name_off {
if (dev->device.numa_node == SOCKET_ID_ANY)
dev->device.numa_node = rte_socket_id();
- eth_dev_vhost_create(dev, iface_name, queues, dev->device.numa_node,
- flags, disable_flags);
+ ret = eth_dev_vhost_create(dev, iface_name, queues,
+ dev->device.numa_node, flags, disable_flags);
+ if (ret == -1)
+ VHOST_LOG(ERR, "Failed to create %s", name);
out_free:
rte_kvargs_free(kvlist);
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] net/vhost: fix return value of vhost creates not checked
2019-12-16 1:05 [dpdk-dev] [PATCH] net/vhost: fix return value of vhost creates not checked Yunjian Wang
@ 2019-12-16 5:33 ` Tiwei Bie
2019-12-16 6:38 ` wangyunjian
0 siblings, 1 reply; 4+ messages in thread
From: Tiwei Bie @ 2019-12-16 5:33 UTC (permalink / raw)
To: Yunjian Wang; +Cc: dev, maxime.coquelin, zhihong.wang, xudingke, stable
On Mon, Dec 16, 2019 at 09:05:59AM +0800, Yunjian Wang wrote:
> The function eth_dev_vhost_create() could return errors,
> the return value need to be checked.
>
> Fixes: ee584e9710b9 ("vhost: add driver on top of the library")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
> drivers/net/vhost/rte_eth_vhost.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
> index 46f01a7..7e4faf2 100644
> --- a/drivers/net/vhost/rte_eth_vhost.c
> +++ b/drivers/net/vhost/rte_eth_vhost.c
> @@ -1455,8 +1455,10 @@ struct vhost_xstats_name_off {
> if (dev->device.numa_node == SOCKET_ID_ANY)
> dev->device.numa_node = rte_socket_id();
>
> - eth_dev_vhost_create(dev, iface_name, queues, dev->device.numa_node,
> - flags, disable_flags);
> + ret = eth_dev_vhost_create(dev, iface_name, queues,
> + dev->device.numa_node, flags, disable_flags);
> + if (ret == -1)
> + VHOST_LOG(ERR, "Failed to create %s", name);
This will set "ret" to port id on success,
but we shouldn't return port id in probe.
>
> out_free:
> rte_kvargs_free(kvlist);
> --
> 1.8.3.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] net/vhost: fix return value of vhost creates not checked
2019-12-16 5:33 ` Tiwei Bie
@ 2019-12-16 6:38 ` wangyunjian
2019-12-17 1:21 ` Tiwei Bie
0 siblings, 1 reply; 4+ messages in thread
From: wangyunjian @ 2019-12-16 6:38 UTC (permalink / raw)
To: Tiwei Bie; +Cc: dev, maxime.coquelin, zhihong.wang, xudingke, stable
> -----Original Message-----
> From: Tiwei Bie [mailto:tiwei.bie@intel.com]
> Sent: Monday, December 16, 2019 1:33 PM
> To: wangyunjian <wangyunjian@huawei.com>
> Cc: dev@dpdk.org; maxime.coquelin@redhat.com; zhihong.wang@intel.com;
> xudingke <xudingke@huawei.com>; stable@dpdk.org
> Subject: Re: [PATCH] net/vhost: fix return value of vhost creates not checked
>
> On Mon, Dec 16, 2019 at 09:05:59AM +0800, Yunjian Wang wrote:
> > The function eth_dev_vhost_create() could return errors, the return
> > value need to be checked.
> >
> > Fixes: ee584e9710b9 ("vhost: add driver on top of the library")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> > ---
> > drivers/net/vhost/rte_eth_vhost.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/vhost/rte_eth_vhost.c
> > b/drivers/net/vhost/rte_eth_vhost.c
> > index 46f01a7..7e4faf2 100644
> > --- a/drivers/net/vhost/rte_eth_vhost.c
> > +++ b/drivers/net/vhost/rte_eth_vhost.c
> > @@ -1455,8 +1455,10 @@ struct vhost_xstats_name_off {
> > if (dev->device.numa_node == SOCKET_ID_ANY)
> > dev->device.numa_node = rte_socket_id();
> >
> > - eth_dev_vhost_create(dev, iface_name, queues, dev->device.numa_node,
> > - flags, disable_flags);
> > + ret = eth_dev_vhost_create(dev, iface_name, queues,
> > + dev->device.numa_node, flags, disable_flags);
> > + if (ret == -1)
> > + VHOST_LOG(ERR, "Failed to create %s", name);
>
> This will set "ret" to port id on success, but we shouldn't return port id in
> probe.
OK, I agree. How about function eth_dev_vhost_create can return 0 on success?
Thanks
Yunjian
>
> >
> > out_free:
> > rte_kvargs_free(kvlist);
> > --
> > 1.8.3.1
> >
> >
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] net/vhost: fix return value of vhost creates not checked
2019-12-16 6:38 ` wangyunjian
@ 2019-12-17 1:21 ` Tiwei Bie
0 siblings, 0 replies; 4+ messages in thread
From: Tiwei Bie @ 2019-12-17 1:21 UTC (permalink / raw)
To: wangyunjian; +Cc: dev, maxime.coquelin, zhihong.wang, xudingke, stable
On Mon, Dec 16, 2019 at 06:38:28AM +0000, wangyunjian wrote:
> > -----Original Message-----
> > From: Tiwei Bie [mailto:tiwei.bie@intel.com]
> > Sent: Monday, December 16, 2019 1:33 PM
> > To: wangyunjian <wangyunjian@huawei.com>
> > Cc: dev@dpdk.org; maxime.coquelin@redhat.com; zhihong.wang@intel.com;
> > xudingke <xudingke@huawei.com>; stable@dpdk.org
> > Subject: Re: [PATCH] net/vhost: fix return value of vhost creates not checked
> >
> > On Mon, Dec 16, 2019 at 09:05:59AM +0800, Yunjian Wang wrote:
> > > The function eth_dev_vhost_create() could return errors, the return
> > > value need to be checked.
> > >
> > > Fixes: ee584e9710b9 ("vhost: add driver on top of the library")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> > > ---
> > > drivers/net/vhost/rte_eth_vhost.c | 6 ++++--
> > > 1 file changed, 4 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/net/vhost/rte_eth_vhost.c
> > > b/drivers/net/vhost/rte_eth_vhost.c
> > > index 46f01a7..7e4faf2 100644
> > > --- a/drivers/net/vhost/rte_eth_vhost.c
> > > +++ b/drivers/net/vhost/rte_eth_vhost.c
> > > @@ -1455,8 +1455,10 @@ struct vhost_xstats_name_off {
> > > if (dev->device.numa_node == SOCKET_ID_ANY)
> > > dev->device.numa_node = rte_socket_id();
> > >
> > > - eth_dev_vhost_create(dev, iface_name, queues, dev->device.numa_node,
> > > - flags, disable_flags);
> > > + ret = eth_dev_vhost_create(dev, iface_name, queues,
> > > + dev->device.numa_node, flags, disable_flags);
> > > + if (ret == -1)
> > > + VHOST_LOG(ERR, "Failed to create %s", name);
> >
> > This will set "ret" to port id on success, but we shouldn't return port id in
> > probe.
>
> OK, I agree. How about function eth_dev_vhost_create can return 0 on success?
Sounds good to me.
>
> Thanks
> Yunjian
>
> >
> > >
> > > out_free:
> > > rte_kvargs_free(kvlist);
> > > --
> > > 1.8.3.1
> > >
> > >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-17 1:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-16 1:05 [dpdk-dev] [PATCH] net/vhost: fix return value of vhost creates not checked Yunjian Wang
2019-12-16 5:33 ` Tiwei Bie
2019-12-16 6:38 ` wangyunjian
2019-12-17 1:21 ` Tiwei Bie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).