From: Tiwei Bie <tiwei.bie@intel.com>
To: Adrian Moreno <amorenoz@redhat.com>
Cc: dev@dpdk.org, zhihong.wang@intel.com, maxime.coquelin@redhat.com,
huawei.xie@intel.com
Subject: Re: [dpdk-dev] [PATCH] vhost: Add dynamic logging system
Date: Mon, 16 Dec 2019 13:55:05 +0800 [thread overview]
Message-ID: <20191216055505.GA188664@___> (raw)
In-Reply-To: <20191204150729.31816-1-amorenoz@redhat.com>
On Wed, Dec 04, 2019 at 04:07:29PM +0100, Adrian Moreno wrote:
> Currently there are a couple of limitations on the logging system: Most
> of the logs are compiled out and both datapath and controlpath logs
> share the same loglevel.
>
> This patch tries to help fix that situation by:
> - Splitting control plane and data plane logs
> - Making control plane logs dynamic while keeping data plane logs
> compiled out by default for log levels lower than the INFO.
>
> As a result, two macros are introduced:
> - VHOST_LOG_CONFIG(LEVEL, ...): Config path logging. Level can be
> dynamically controlled by "lib.vhost.config"
>
> - VHOST_LOG_DATA(LEVEL, ...): Data path logging. Level can be dynamically
> controlled by "lib.vhost.data". Every log macro with a level lower than
> RTE_LOG_DP_LEVEL (which defaults to RTE_LOG_INFO) will be compiled out.
>
> Signed-off-by: Adrian Moreno <amorenoz@redhat.com>
Acked-by: Tiwei Bie <tiwei.bie@intel.com>
next prev parent reply other threads:[~2019-12-16 5:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 15:07 Adrian Moreno
2019-12-16 5:55 ` Tiwei Bie [this message]
2020-01-09 14:40 ` Maxime Coquelin
2020-01-09 15:45 ` Maxime Coquelin
2020-01-09 15:50 ` Maxime Coquelin
2020-01-09 16:36 ` Adrian Moreno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191216055505.GA188664@___ \
--to=tiwei.bie@intel.com \
--cc=amorenoz@redhat.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).