From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3BA3A04B3; Mon, 16 Dec 2019 06:54:51 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 08F241C0D4; Mon, 16 Dec 2019 06:54:51 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id B293D1C0D0 for ; Mon, 16 Dec 2019 06:54:48 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Dec 2019 21:54:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,320,1571727600"; d="scan'208";a="205002972" Received: from dpdk-virtio-tbie-2.sh.intel.com (HELO ___) ([10.67.104.74]) by orsmga007.jf.intel.com with ESMTP; 15 Dec 2019 21:54:46 -0800 Date: Mon, 16 Dec 2019 13:55:05 +0800 From: Tiwei Bie To: Adrian Moreno Cc: dev@dpdk.org, zhihong.wang@intel.com, maxime.coquelin@redhat.com, huawei.xie@intel.com Message-ID: <20191216055505.GA188664@___> References: <20191204150729.31816-1-amorenoz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191204150729.31816-1-amorenoz@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] vhost: Add dynamic logging system X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Dec 04, 2019 at 04:07:29PM +0100, Adrian Moreno wrote: > Currently there are a couple of limitations on the logging system: Most > of the logs are compiled out and both datapath and controlpath logs > share the same loglevel. > > This patch tries to help fix that situation by: > - Splitting control plane and data plane logs > - Making control plane logs dynamic while keeping data plane logs > compiled out by default for log levels lower than the INFO. > > As a result, two macros are introduced: > - VHOST_LOG_CONFIG(LEVEL, ...): Config path logging. Level can be > dynamically controlled by "lib.vhost.config" > > - VHOST_LOG_DATA(LEVEL, ...): Data path logging. Level can be dynamically > controlled by "lib.vhost.data". Every log macro with a level lower than > RTE_LOG_DP_LEVEL (which defaults to RTE_LOG_INFO) will be compiled out. > > Signed-off-by: Adrian Moreno Acked-by: Tiwei Bie