DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tiwei Bie <tiwei.bie@intel.com>
To: wangyunjian <wangyunjian@huawei.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
	"zhihong.wang@intel.com" <zhihong.wang@intel.com>,
	xudingke <xudingke@huawei.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/vhost: fix return value of vhost creates not checked
Date: Tue, 17 Dec 2019 09:21:45 +0800	[thread overview]
Message-ID: <20191217012145.GA211317@___> (raw)
In-Reply-To: <34EFBCA9F01B0748BEB6B629CE643AE60CDB8DA7@DGGEMM533-MBX.china.huawei.com>

On Mon, Dec 16, 2019 at 06:38:28AM +0000, wangyunjian wrote:
> > -----Original Message-----
> > From: Tiwei Bie [mailto:tiwei.bie@intel.com]
> > Sent: Monday, December 16, 2019 1:33 PM
> > To: wangyunjian <wangyunjian@huawei.com>
> > Cc: dev@dpdk.org; maxime.coquelin@redhat.com; zhihong.wang@intel.com;
> > xudingke <xudingke@huawei.com>; stable@dpdk.org
> > Subject: Re: [PATCH] net/vhost: fix return value of vhost creates not checked
> > 
> > On Mon, Dec 16, 2019 at 09:05:59AM +0800, Yunjian Wang wrote:
> > > The function eth_dev_vhost_create() could return errors, the return
> > > value need to be checked.
> > >
> > > Fixes: ee584e9710b9 ("vhost: add driver on top of the library")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> > > ---
> > >  drivers/net/vhost/rte_eth_vhost.c | 6 ++++--
> > >  1 file changed, 4 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/net/vhost/rte_eth_vhost.c
> > > b/drivers/net/vhost/rte_eth_vhost.c
> > > index 46f01a7..7e4faf2 100644
> > > --- a/drivers/net/vhost/rte_eth_vhost.c
> > > +++ b/drivers/net/vhost/rte_eth_vhost.c
> > > @@ -1455,8 +1455,10 @@ struct vhost_xstats_name_off {
> > >  	if (dev->device.numa_node == SOCKET_ID_ANY)
> > >  		dev->device.numa_node = rte_socket_id();
> > >
> > > -	eth_dev_vhost_create(dev, iface_name, queues, dev->device.numa_node,
> > > -		flags, disable_flags);
> > > +	ret = eth_dev_vhost_create(dev, iface_name, queues,
> > > +			dev->device.numa_node, flags, disable_flags);
> > > +	if (ret == -1)
> > > +		VHOST_LOG(ERR, "Failed to create %s", name);
> > 
> > This will set "ret" to port id on success, but we shouldn't return port id in
> > probe.
> 
> OK, I agree. How about function eth_dev_vhost_create can return 0 on success?

Sounds good to me.

> 
> Thanks
> Yunjian
> 
> > 
> > >
> > >  out_free:
> > >  	rte_kvargs_free(kvlist);
> > > --
> > > 1.8.3.1
> > >
> > >

      reply	other threads:[~2019-12-17  1:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-16  1:05 Yunjian Wang
2019-12-16  5:33 ` Tiwei Bie
2019-12-16  6:38   ` wangyunjian
2019-12-17  1:21     ` Tiwei Bie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191217012145.GA211317@___ \
    --to=tiwei.bie@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=stable@dpdk.org \
    --cc=wangyunjian@huawei.com \
    --cc=xudingke@huawei.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).