From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02696A050F; Wed, 18 Dec 2019 03:13:24 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C77641BEC4; Wed, 18 Dec 2019 03:13:23 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id D95DA1BE9E; Wed, 18 Dec 2019 03:13:21 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Dec 2019 18:13:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,327,1571727600"; d="scan'208";a="390031424" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga005.jf.intel.com with ESMTP; 17 Dec 2019 18:13:19 -0800 Date: Wed, 18 Dec 2019 10:08:32 +0800 From: Ye Xiaolong To: Chenxu Di Cc: dev@dpdk.org, Yang Qiming , stable@dpdk.org Message-ID: <20191218020832.GL59123@intel.com> References: <20191211090603.62152-1-chenxux.di@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191211090603.62152-1-chenxux.di@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix port close in FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/11, Chenxu Di wrote: >FreeBSD OS doesn't support igb_uio interrupt, so it will fail when >unregister the interrupt callback in port close. We can fix the issue by >passing -ENOENT when check the return value of unregister interrupt >callback function. > >Fixes: ac89d46096d5 ("net/i40e: release port upon close") >Cc: stable@dpdk.org > >Signed-off-by: Chenxu Di >--- > drivers/net/i40e/i40e_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c >index 5999c964b..8b2500391 100644 >--- a/drivers/net/i40e/i40e_ethdev.c >+++ b/drivers/net/i40e/i40e_ethdev.c >@@ -2594,7 +2594,7 @@ i40e_dev_close(struct rte_eth_dev *dev) > do { > ret = rte_intr_callback_unregister(intr_handle, > i40e_dev_interrupt_handler, dev); >- if (ret >= 0) { >+ if (ret >= 0 || ret == -ENOENT) { > break; > } else if (ret != -EAGAIN) { > PMD_INIT_LOG(ERR, >-- >2.17.1 > Acked-by: Xiaolong Ye Applied to dpdk-next-net-intel, Thanks.