From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96E6BA04F3; Fri, 20 Dec 2019 01:16:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AE9051BE8A; Fri, 20 Dec 2019 01:16:55 +0100 (CET) Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id 7FE5D1B9BF for ; Fri, 20 Dec 2019 01:16:54 +0100 (CET) Received: by mail-pg1-f193.google.com with SMTP id x8so3996393pgk.8 for ; Thu, 19 Dec 2019 16:16:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CU4Dml+a4Rt97/upkytqevLs/Hp95+JCGTeyTZLpwoY=; b=sEa4jkS8japtXRQAZeAs28amLC2veyH880vp81wzYrfmgbi5GSxiBerVmxTefry0Q1 TtNapFMSEESVJGtrcp2RwhpN4DoJDamEjL8fa4ub29kNNDMLJMlh+xupX/KQ2ovJtvrC ZMFmVqCPIDfbQzhPYh3i9jRosCiLg2Nz3bVY8wR3YaSsUeC9ND9Smgzw6fL+wf24MTCK 1MoO8cVp2zHW6dlrH7L0pUdFp4/TG/IJkDlaILtJ00lSizYdW/Sv6F5JjkA501PHNBax vwzv4hWwE3ZseNTNJbyBFp86KrV+aVtrDmG0RxvbsL9F3OmUilGvhbTklaWPQX0hDsSz dGEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CU4Dml+a4Rt97/upkytqevLs/Hp95+JCGTeyTZLpwoY=; b=PbTqkMCenlsqe6x6BYktXr4qM9IzCnrdRDwA3Vj04Ug5Ioo6FrS/ZlbgIFMo7eHDZj qRGHbRbEWPwOnfEWMrPt4I0hToL2nG6op3NYaw0wqstpgtSof8lRx89kVhx287n9zf6M uetfxtN+lgi15Ioq2vCWUB09v7DSgr8L7dmFtqH8w48DR0Fiq/JcnOLVzJ5zBsd4CKoQ AZwr2yad99oLcTjrDxbGBeqG6S4zFgAi8OAfomAWjPBfwyix0CY5uFD1y3lh8k1JWlsY +aZtDQ3dHs3QeBYng6dQ+q5tCgamn8KYz2Zxu6DBmDo6Y8q5JClzGuLg8aU5b449Rtmc CSBw== X-Gm-Message-State: APjAAAVd5QlPGo3p42l0fHGNhUl3YXLlOIDr5Y71rCGxSZBhw5LOO/8J p3AYhPYQuVrDoG0RuMjAMfDkZ8XCPYl+vQ== X-Google-Smtp-Source: APXvYqxffhxAuHtt1KazFoRheimtJYl8+dsRq+m4los/Md92Av0uZaOoFnPWvUrsxHiI2sXVflb7UQ== X-Received: by 2002:a63:3f4f:: with SMTP id m76mr11599861pga.353.1576801013319; Thu, 19 Dec 2019 16:16:53 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 65sm10183241pfu.140.2019.12.19.16.16.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2019 16:16:53 -0800 (PST) Date: Thu, 19 Dec 2019 16:16:45 -0800 From: Stephen Hemminger To: Alfredo Cardigliano Cc: dev@dpdk.org Message-ID: <20191219161645.7309a690@hermes.lan> In-Reply-To: <20191219221847.29989-3-cardigliano@ntop.org> References: <20191219221847.29989-1-cardigliano@ntop.org> <20191219221847.29989-3-cardigliano@ntop.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 02/17] net/ionic: add hardware structures definitions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 19 Dec 2019 23:18:32 +0100 Alfredo Cardigliano wrote: > + > +#pragma pack(push, 1) > + Really, packing leads to unaligned data structures and is generally a bad idea.