From: Stephen Hemminger <stephen@networkplumber.org>
To: Alfredo Cardigliano <cardigliano@ntop.org>
Cc: John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 04/17] net/ionic: register and initialize the adapter
Date: Thu, 19 Dec 2019 16:19:20 -0800 [thread overview]
Message-ID: <20191219161920.6ee8e849@hermes.lan> (raw)
In-Reply-To: <20191219221847.29989-5-cardigliano@ntop.org>
On Thu, 19 Dec 2019 23:18:34 +0100
Alfredo Cardigliano <cardigliano@ntop.org> wrote:
> + adapter = rte_zmalloc("ionic", sizeof(*adapter), 0);
> +
> + if (!adapter) {
Don't need a blank line here; better to have assignment and check next to each other.
You probably want to use rte_zmalloc_socket to make sure that the adapter memory
is on the same numa node as the device.
next prev parent reply other threads:[~2019-12-20 0:19 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 22:18 [dpdk-dev] [PATCH v4 00/17] Introduces net/ionic PMD Alfredo Cardigliano
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 01/17] net/ionic: add skeleton Alfredo Cardigliano
2020-01-07 16:34 ` Ferruh Yigit
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 02/17] net/ionic: add hardware structures definitions Alfredo Cardigliano
2019-12-20 0:16 ` Stephen Hemminger
2020-01-03 8:22 ` Alfredo Cardigliano
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 03/17] net/ionic: add log Alfredo Cardigliano
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 04/17] net/ionic: register and initialize the adapter Alfredo Cardigliano
2019-12-20 0:19 ` Stephen Hemminger [this message]
2019-12-20 0:23 ` Stephen Hemminger
2019-12-20 0:24 ` Stephen Hemminger
2019-12-20 0:27 ` Stephen Hemminger
2020-01-07 16:35 ` Ferruh Yigit
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 05/17] net/ionic: add port management commands Alfredo Cardigliano
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 06/17] net/ionic: add basic lif support Alfredo Cardigliano
2019-12-20 1:12 ` Stephen Hemminger
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 07/17] net/ionic: add doorbells Alfredo Cardigliano
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 08/17] net/ionic: add adminq support Alfredo Cardigliano
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 09/17] net/ionic: add notifyq support Alfredo Cardigliano
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 10/17] net/ionic: add basic port operations Alfredo Cardigliano
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 11/17] net/ionic: add RX filters support Alfredo Cardigliano
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 12/17] net/ionic: add Flow Control support Alfredo Cardigliano
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 13/17] net/ionic: add RX and TX handling Alfredo Cardigliano
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 14/17] net/ionic: add RSS support Alfredo Cardigliano
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 15/17] net/ionic: add stats Alfredo Cardigliano
2019-12-20 0:28 ` Stephen Hemminger
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 16/17] net/ionic: add TX checksum support Alfredo Cardigliano
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 17/17] net/ionic: read fw version Alfredo Cardigliano
2020-01-07 16:34 ` [dpdk-dev] [PATCH v4 00/17] Introduces net/ionic PMD Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219161920.6ee8e849@hermes.lan \
--to=stephen@networkplumber.org \
--cc=anatoly.burakov@intel.com \
--cc=cardigliano@ntop.org \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).