From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55AA5A04F3; Fri, 20 Dec 2019 01:19:26 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7BCDB1BE8A; Fri, 20 Dec 2019 01:19:25 +0100 (CET) Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id AA8641BC25 for ; Fri, 20 Dec 2019 01:19:24 +0100 (CET) Received: by mail-pl1-f195.google.com with SMTP id c13so3325987pls.0 for ; Thu, 19 Dec 2019 16:19:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6T3iluKQmitBHB7q/nQxOBJS0RYRI+OTD5cLwRGzv78=; b=FIiZEncPlyLg3RVqHIS8Orr7R90VUDOlhC1S3Ecji9G+Sb6k+zUiz6xc6ebceUdHMy /3apnCgFuP4Vh+qkFN1cKwfeYCqWZpcDdK6oU9LhDRVvA0Mq3dWsB6UWK5Fu8oUXhcZ3 E489DHDmEi6HnF6RyKhljf5Vu5bDmql1bePrqlbQLfODx6lP0UOuXtcHqSrnGxxiXAxz r1JnyCh6IxYsVxUaC6ZfUAyIQSahNYJ1plJ8btn/ccDRYhNsw/4hhR/XwHtuaVSjmshE GLufGVwGdMMpwfuBgJ25x531I5f3hnxnjSkjXHK/njEKNxZixGkcXfnQd2QF0+9ATwlf LVyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6T3iluKQmitBHB7q/nQxOBJS0RYRI+OTD5cLwRGzv78=; b=tbSjSsecCBulqxMADKNzIqkN7/9WaFNTZWZLEyzztjsYnMX9XexI0RF4rVRHlpp9Xx 8hsmUpc0bgdE9/iS7jppEuEqDRQX40fjsTu/ODOPeu4jJxBZ7/ZeyDW8ecFAbHlVD7v0 hG6UxHI7gxLd3x5VNt0MHll9/Nd7K5HF/OIRGM0YivqTc7ISDMkPWsGezZfP5W7lpgPp hXvQsdvxllBUjAxOqnBfezWiWx4KWH0G96rI8xbFGcJqMg6+EjMnel8nH6nvre04Zgrq JdwtbiaqTnIhgt2MnNHCjkaZbHZ5ouUtssNMevxrfXnqNvHxLLcYrFIx3bvELmLcHoMF A3Jw== X-Gm-Message-State: APjAAAXATAghsVU8yjysNTXr+TjZgEz6i0nrxsK/cXITNFjTe2hEQq5v 9Ee2dx/vOaqz5sJXICyKd8VyOQ== X-Google-Smtp-Source: APXvYqyLcB6au49/MHkQrltyS6tKcbSk4y9JrKQLGKJQvYKKtLYCoiYQ7cVGcWiiqoN6GHtbtgYeow== X-Received: by 2002:a17:902:321:: with SMTP id 30mr11740483pld.153.1576801163835; Thu, 19 Dec 2019 16:19:23 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id p124sm10042254pfb.52.2019.12.19.16.19.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2019 16:19:23 -0800 (PST) Date: Thu, 19 Dec 2019 16:19:20 -0800 From: Stephen Hemminger To: Alfredo Cardigliano Cc: John McNamara , Marko Kovacevic , Anatoly Burakov , dev@dpdk.org Message-ID: <20191219161920.6ee8e849@hermes.lan> In-Reply-To: <20191219221847.29989-5-cardigliano@ntop.org> References: <20191219221847.29989-1-cardigliano@ntop.org> <20191219221847.29989-5-cardigliano@ntop.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 04/17] net/ionic: register and initialize the adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 19 Dec 2019 23:18:34 +0100 Alfredo Cardigliano wrote: > + adapter = rte_zmalloc("ionic", sizeof(*adapter), 0); > + > + if (!adapter) { Don't need a blank line here; better to have assignment and check next to each other. You probably want to use rte_zmalloc_socket to make sure that the adapter memory is on the same numa node as the device.