From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1A439A04F3;
	Fri, 20 Dec 2019 01:29:05 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id CAE721BE8E;
	Fri, 20 Dec 2019 01:29:04 +0100 (CET)
Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com
 [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 15E6C1BE8A
 for <dev@dpdk.org>; Fri, 20 Dec 2019 01:29:03 +0100 (CET)
Received: by mail-pf1-f194.google.com with SMTP id p14so4222081pfn.4
 for <dev@dpdk.org>; Thu, 19 Dec 2019 16:29:03 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=sjJlOC9KAla4a4GzFBaCAAQznzuX/RjsM90BmUyHwX4=;
 b=1wdfVb4ql9UgpObA/cyNgPNm/dVp7CCwefr4Mg+4lkgmibt2Ds+XfNLw1tkVj0J3Z2
 ejpUKJzLfEinq/25HfPZwHeMIDaaScZA5iyDdd6yzIptfICY70Vm2B3bFBF03Pwi5BSD
 rILo0Qlc67aw6LJmpqMtbTXoRVzX1j6keaU/RHDFJITMejeQl3Od70LwpCUDQjER/Hb2
 8d6/yyLITSNJjYkY/nyCG7SfBxNgIXc24pfVUzuGtd+ChwK3G1zj0cOA1fFeS7tBNXqD
 cOWHWwGYtZv4jp7xBJr/FiS2bTAqjYQ7mu2TLj5pfbNOYHJ+0ubEEQtGiniKezqKXpsT
 ycVg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=sjJlOC9KAla4a4GzFBaCAAQznzuX/RjsM90BmUyHwX4=;
 b=lMLichxmVeqM1Ox6R1T3Cq8dRG00Ei7ET6Y+RGpQCOQemwzqJJjKIYDJj4z3OmGywU
 py3e581EY6rOtyY5uG2T3dsUYlGtxskBzIsu0/Q3RMOGMVcVpXBf/l+NMM3VWu4jRGGo
 GiAIB9jO8kWVfc1IwFp801NWZXQEUAmysmiSGWV16Ae7NxoobO8ZxD+IU6o/2AMzprwB
 rs222PpnJBdcf/LGDlmSN17z4QWcgEj2tl6PwMLug4aBXFpXBi967k/A/AodWt76fMPH
 TeQvjHVbVRKbZQUZLMPLTiyaKxLWbcHYyYaiwEk8lMytzD/9IcjJMT7wV6uaj/eiE9yV
 PK4Q==
X-Gm-Message-State: APjAAAWTVv0mR3QDBbtQisQRqQxhJDRtR2Tg+lDIEUbwxgd7N3JxcL8Q
 j8SxMEJarlwP8UQ9Rpt3P4HmpQ==
X-Google-Smtp-Source: APXvYqyL904Dt4GDP0LCOZm+tIkiQ+MfGyFZdpxI/UDl5akhMIL6j/5vnQClu3DnQwOqPeqcGnOX4w==
X-Received: by 2002:a63:1346:: with SMTP id 6mr12091456pgt.111.1576801742095; 
 Thu, 19 Dec 2019 16:29:02 -0800 (PST)
Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])
 by smtp.gmail.com with ESMTPSA id a22sm10723423pfk.108.2019.12.19.16.29.01
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 19 Dec 2019 16:29:01 -0800 (PST)
Date: Thu, 19 Dec 2019 16:28:59 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Alfredo Cardigliano <cardigliano@ntop.org>
Cc: John McNamara <john.mcnamara@intel.com>, Marko Kovacevic
 <marko.kovacevic@intel.com>, dev@dpdk.org
Message-ID: <20191219162859.367bb8be@hermes.lan>
In-Reply-To: <20191219221847.29989-16-cardigliano@ntop.org>
References: <20191219221847.29989-1-cardigliano@ntop.org>
 <20191219221847.29989-16-cardigliano@ntop.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v4 15/17] net/ionic: add stats
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 19 Dec 2019 23:18:45 +0100
Alfredo Cardigliano <cardigliano@ntop.org> wrote:

> +
> +void
> +ionic_lif_get_stats(struct ionic_lif *lif, struct rte_eth_stats *stats)
> +{

It is clearer which parameter is input (vs output) if you mark lif as const here.