From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D3D4A04F3; Fri, 20 Dec 2019 02:12:55 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 253411BDFD; Fri, 20 Dec 2019 02:12:54 +0100 (CET) Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id 233F71BC25 for ; Fri, 20 Dec 2019 02:12:52 +0100 (CET) Received: by mail-pg1-f193.google.com with SMTP id k3so4082680pgc.3 for ; Thu, 19 Dec 2019 17:12:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/ji1wDHaSl5rX8+7AIRONXb2vks1CK4Ct78ZvjUSYaA=; b=CX9HdLhWxfYFKPBwAiFd3vbdvto2H05h9tjnGWa3Fh+RrmKxF0M+xHDCST11YYHCU8 LgzMdoMGtDIPGUTTtlQurHoa/i3tIIEfZkO1WC4rXYp7JRllhA3S3V1LriOf3skCB+ad 3pigp/2JrHs38LVHTDLNkH+hQzGDyeGF6w2mynlZ3yPOd+wyxKsls43yhs6STCdF8uMV SygttX/GjO+cbFElfu4rLh1Yvz5y2mO4Tv38eJChs7YLm2ywGzurRBg2S9+c9EzrDPy7 h9g8cWRNMIvOFZ322GVQy3EHGTpH1CFSIVjgrchfYv0iQfU8rCwTPV/Yva1lnwY0rBUx nW5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/ji1wDHaSl5rX8+7AIRONXb2vks1CK4Ct78ZvjUSYaA=; b=O0wBlh1+rmvZDYL7tdd5DID/4dU6HHhmzsn5pxvZ0WKyCqNT8nRSd8HShRGXK4BtiN 5Qvhsf9t14en1hIhlDDy+nXxI8y+mP66zcnSe/InWiGeLVkrZ1ZbKuTWmthrHWMKydz4 emBgMrTyDGlPQP/g+JtHMvX9Xg6uSRHFKle5epHlJWo29ieUuhEpQ4dmEGfSZqiO6y1R vzPQ8EG10j78aVw8QmW8tygcVy8HkUqvChcoqqI5CrbaLykR2DSf1Gs2mTTzMls19Yr3 e+rhjCA52GUk+5bThIYVa3mX6aNlU1FPnftA6Zgae5iltOsyhkVERm/gbwRTbHkwCspO 6uJA== X-Gm-Message-State: APjAAAWrj1D/zYnwKdqlEyrYtsdYkeDPkOblt5+l5T/IZxr6TZvCPTIQ WCcpsLzPFxtGTV5Kzx4hNCBEOg== X-Google-Smtp-Source: APXvYqznam/QRByTYHTD9Y2oD4HpDqiqBtOM1Whm94BVCMszayLCLn2AnczDpLHqexeQH3uQB+nRLw== X-Received: by 2002:a63:1807:: with SMTP id y7mr11532127pgl.94.1576804372005; Thu, 19 Dec 2019 17:12:52 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id y128sm8273154pfy.146.2019.12.19.17.12.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2019 17:12:51 -0800 (PST) Date: Thu, 19 Dec 2019 17:12:43 -0800 From: Stephen Hemminger To: Alfredo Cardigliano Cc: Anatoly Burakov , dev@dpdk.org Message-ID: <20191219171243.29ff32ea@hermes.lan> In-Reply-To: <20191219221847.29989-7-cardigliano@ntop.org> References: <20191219221847.29989-1-cardigliano@ntop.org> <20191219221847.29989-7-cardigliano@ntop.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 06/17] net/ionic: add basic lif support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 19 Dec 2019 23:18:36 +0100 Alfredo Cardigliano wrote: > diff --git a/drivers/net/ionic/ionic.h b/drivers/net/ionic/ionic.h > index a29f0bb89..b6ef63161 100644 > --- a/drivers/net/ionic/ionic.h > +++ b/drivers/net/ionic/ionic.h > @@ -49,7 +49,12 @@ struct ionic_adapter { > struct ionic_dev idev; > struct ionic_dev_bar bars[IONIC_BARS_MAX]; > struct ionic_identity ident; > + struct ionic_lif *lifs[IONIC_LIFS_MAX] You are making 8K array on the stack, do you really need all that?