From: "Wei Hu (Xavier)" <huwei013@chinasoftinc.com>
To: <dev@dpdk.org>
Subject: [dpdk-dev] [PATCH v3 8/9] net/hns3: remove the unnecessary assignment
Date: Sat, 21 Dec 2019 18:32:52 +0800 [thread overview]
Message-ID: <20191221103253.30746-9-huwei013@chinasoftinc.com> (raw)
In-Reply-To: <20191221103253.30746-1-huwei013@chinasoftinc.com>
From: "Wei Hu (Xavier)" <xavier.huwei@huawei.com>
This patch removes the unncessary assignment in the '.tx_pkt_burst' ops
implementation function to avoid performance loss.
Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
Signed-off-by: Yisen Zhuang <yisen.zhuang@huawei.com>
---
drivers/net/hns3/hns3_rxtx.c | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c
index d9219d123..003a5bde4 100644
--- a/drivers/net/hns3/hns3_rxtx.c
+++ b/drivers/net/hns3/hns3_rxtx.c
@@ -1181,8 +1181,7 @@ hns3_tx_free_useless_buffer(struct hns3_tx_queue *txq)
(tx_next_use != tx_next_clean || tx_bd_ready < tx_bd_max)) {
mbuf = tx_bak_pkt->mbuf;
if (mbuf) {
- mbuf->next = NULL;
- rte_pktmbuf_free(mbuf);
+ rte_pktmbuf_free_seg(mbuf);
tx_bak_pkt->mbuf = NULL;
}
@@ -1600,9 +1599,7 @@ hns3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
struct rte_mbuf *new_pkt;
struct rte_mbuf *tx_pkt;
struct rte_mbuf *m_seg;
- struct rte_mbuf *temp;
uint32_t nb_hold = 0;
- uint16_t tx_next_clean;
uint16_t tx_next_use;
uint16_t tx_bd_ready;
uint16_t tx_pkt_num;
@@ -1617,11 +1614,8 @@ hns3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
if (tx_bd_ready == 0)
return 0;
- tx_next_clean = txq->next_to_clean;
tx_next_use = txq->next_to_use;
tx_bd_max = txq->nb_tx_desc;
- tx_bak_pkt = &txq->sw_ring[tx_next_clean];
-
tx_pkt_num = (tx_bd_ready < nb_pkts) ? tx_bd_ready : nb_pkts;
/* send packets */
@@ -1676,9 +1670,8 @@ hns3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
i = 0;
do {
fill_desc(txq, tx_next_use, m_seg, (i == 0), 0);
- temp = m_seg->next;
tx_bak_pkt->mbuf = m_seg;
- m_seg = temp;
+ m_seg = m_seg->next;
tx_next_use++;
tx_bak_pkt++;
if (tx_next_use >= tx_bd_max) {
@@ -1697,7 +1690,6 @@ hns3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
if (likely(nb_tx)) {
hns3_queue_xmit(txq, nb_hold);
- txq->next_to_clean = tx_next_clean;
txq->tx_bd_ready = tx_bd_ready - nb_hold;
}
--
2.23.0
next prev parent reply other threads:[~2019-12-21 10:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-21 10:32 [dpdk-dev] [PATCH v3 0/9] updates for hns3 PMD driver Wei Hu (Xavier)
2019-12-21 10:32 ` [dpdk-dev] [PATCH v3 1/9] net/hns3: support Rx interrupt Wei Hu (Xavier)
2019-12-21 10:32 ` [dpdk-dev] [PATCH v3 2/9] net/hns3: get link state change through mailbox Wei Hu (Xavier)
2019-12-21 10:32 ` [dpdk-dev] [PATCH v3 3/9] net/hns3: modify the return value of enable msix Wei Hu (Xavier)
2019-12-21 10:32 ` [dpdk-dev] [PATCH v3 4/9] net/hns3: modify custom macro Wei Hu (Xavier)
2019-12-21 10:32 ` [dpdk-dev] [PATCH v3 5/9] net/hns3: optimize RSS's default algorithm Wei Hu (Xavier)
2019-12-21 10:32 ` [dpdk-dev] [PATCH v3 6/9] net/hns3: remove the redundant function call Wei Hu (Xavier)
2019-12-21 10:32 ` [dpdk-dev] [PATCH v3 7/9] net/hns3: remove the redundant variable initialization Wei Hu (Xavier)
2019-12-21 10:32 ` Wei Hu (Xavier) [this message]
2019-12-21 10:32 ` [dpdk-dev] [PATCH v3 9/9] net/hns3: remove the unused macros Wei Hu (Xavier)
2020-01-08 18:18 ` [dpdk-dev] [PATCH v3 0/9] updates for hns3 PMD driver Ferruh Yigit
2020-01-09 3:10 ` Wei Hu (Xavier)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191221103253.30746-9-huwei013@chinasoftinc.com \
--to=huwei013@chinasoftinc.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).