From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD6A9A04B3; Tue, 24 Dec 2019 03:40:18 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 30E1D2BA3; Tue, 24 Dec 2019 03:40:17 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 0CAE11C01 for ; Tue, 24 Dec 2019 03:40:14 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Dec 2019 18:40:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,350,1571727600"; d="scan'208";a="219671350" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga003.jf.intel.com with ESMTP; 23 Dec 2019 18:40:01 -0800 Date: Tue, 24 Dec 2019 10:34:59 +0800 From: Ye Xiaolong To: Guinan Sun Cc: dev@dpdk.org, Beilei Xing , Qi Zhang , Qiming Yang Message-ID: <20191224023459.GE14498@intel.com> References: <20191203145457.72154-1-guinanx.sun@intel.com> <20191223091246.74685-1-guinanx.sun@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191223091246.74685-1-guinanx.sun@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: add support for VF MAC address add and remove X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/23, Guinan Sun wrote: >Ixgbe PMD pf host code needs to support ixgbevf mac address >add and remove. For this purpose, a response was added >between pf and vf to update the mac address. > >Signed-off-by: Guinan Sun >--- >v2: >* Changed the title of commit message. >* Checked null in front of valid ether addr check. >--- > drivers/net/ixgbe/ixgbe_ethdev.h | 1 + > drivers/net/ixgbe/ixgbe_pf.c | 35 ++++++++++++++++++++++++++++++++ > 2 files changed, 36 insertions(+) > >diff --git a/drivers/net/ixgbe/ixgbe_ethdev.h b/drivers/net/ixgbe/ixgbe_ethdev.h >index 76a1b9d18..e1cd8fd16 100644 >--- a/drivers/net/ixgbe/ixgbe_ethdev.h >+++ b/drivers/net/ixgbe/ixgbe_ethdev.h >@@ -270,6 +270,7 @@ struct ixgbe_vf_info { > uint8_t api_version; > uint16_t switch_domain_id; > uint16_t xcast_mode; >+ uint16_t mac_count; > }; > > /* >diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c >index d0d85e138..78fc8c5f1 100644 >--- a/drivers/net/ixgbe/ixgbe_pf.c >+++ b/drivers/net/ixgbe/ixgbe_pf.c >@@ -748,6 +748,37 @@ ixgbe_set_vf_mc_promisc(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf) > return 0; > } > >+static int >+ixgbe_set_vf_macvlan_msg(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf) >+{ >+ struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private); >+ struct ixgbe_vf_info *vf_info = >+ *(IXGBE_DEV_PRIVATE_TO_P_VFDATA(dev->data->dev_private)); >+ uint8_t *new_mac = (uint8_t *)(&msgbuf[1]); >+ int index = (msgbuf[0] & IXGBE_VT_MSGINFO_MASK) >> >+ IXGBE_VT_MSGINFO_SHIFT; >+ >+ if (index) { >+ if (new_mac == NULL) >+ return -1; >+ >+ if (!rte_is_valid_assigned_ether_addr( >+ (struct rte_ether_addr *)new_mac)) { >+ RTE_LOG(ERR, PMD, "set invalid mac vf:%d\n", vf); Better to use PMD_DRV_LOG so as to be aligned with other logging. Thanks, Xiaolong >+ return -1; >+ } >+ >+ vf_info[vf].mac_count++; >+ >+ hw->mac.ops.set_rar(hw, vf_info[vf].mac_count, >+ new_mac, vf, IXGBE_RAH_AV); >+ } else { >+ hw->mac.ops.clear_rar(hw, vf_info[vf].mac_count); >+ vf_info[vf].mac_count = 0; >+ } >+ return 0; >+} >+ > static int > ixgbe_rcv_msg_from_vf(struct rte_eth_dev *dev, uint16_t vf) > { >@@ -835,6 +866,10 @@ ixgbe_rcv_msg_from_vf(struct rte_eth_dev *dev, uint16_t vf) > if (retval == RTE_PMD_IXGBE_MB_EVENT_PROCEED) > retval = ixgbe_set_vf_mc_promisc(dev, vf, msgbuf); > break; >+ case IXGBE_VF_SET_MACVLAN: >+ if (retval == RTE_PMD_IXGBE_MB_EVENT_PROCEED) >+ retval = ixgbe_set_vf_macvlan_msg(dev, vf, msgbuf); >+ break; > default: > PMD_DRV_LOG(DEBUG, "Unhandled Msg %8.8x", (unsigned)msgbuf[0]); > retval = IXGBE_ERR_MBX; >-- >2.17.1 >