From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f52.google.com (mail-lf0-f52.google.com [209.85.215.52]) by dpdk.org (Postfix) with ESMTP id D6CCBD1E8 for ; Tue, 28 Mar 2017 14:04:02 +0200 (CEST) Received: by mail-lf0-f52.google.com with SMTP id z15so36548101lfd.1 for ; Tue, 28 Mar 2017 05:04:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=Vxv8IK5oRkxg3MeHyoyKlCq7RDMIbF+/tLEadYh2DAU=; b=seivhHvnaHnziXsOay0WkCSwJBepr0jF5fx7DQ+qcKQao7Wd11bylFJLSbxnMl/r9G glrD8woYEfubGn66RtqJWWRswB3+2IkRExRKL4UnvRlKPfwX84ZRvIKBglq5WBb4xne1 kgfkr+q1M064ljM+FHzGMIr69B0bGSJC2fRPKqNhIwsHwNeFu6UHTlL45WJU8SfsNVwu FUW66l0Q54bAAnFIM1//3/F8lmS8XmTF5qdchR2MehGb3+V5bGtVO86eVYK92FQzpRgj cfhEo+4q8iRYgEfxugxebVsXTjEn9KaYG5cfkMseN2pb6DIvhTs3SToi4qJE9QXk/zav snLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Vxv8IK5oRkxg3MeHyoyKlCq7RDMIbF+/tLEadYh2DAU=; b=Ng9Yd+NhCahRISuz2NlGx03Hedgzd3GKRL9R8J29g4jtodrzmCWRzNQwYPwv6nmgWx 2JplmdE3xv9tddFBbGAMtpMUL0ASdkytrhl50NSa7rgDvZNwCDZu/N9yrAwwISJzoJgc Bpjs0x1BX0+XVyMKG0Oyl6+JoLiLRe2xVEyIxLneCiELOd9WOIxWvVz/6izI/TbimuDn 3Bqe8CPqLNiBtaYmuDe7iCvZRMjrEYlIOlii7keCfckn17piXjgZ5+bTHOrfybQUbQ+V 3Cy06R8pbgcClP436MalRRgGMxX6ccxPF0uGD+SV+UiuCeniWtEA17xmK3UTykV3Rkf3 p5FQ== X-Gm-Message-State: AFeK/H1JW3SRzLtENjNWArOG08nstt2RP5DxaqWs3MapnfY8xQjlu+GXai/5ykTGATMvBjFS X-Received: by 10.28.62.139 with SMTP id l133mr3690779wma.130.1490702642442; Tue, 28 Mar 2017 05:04:02 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id q188sm3382602wmd.3.2017.03.28.05.04.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Mar 2017 05:04:01 -0700 (PDT) Date: Tue, 28 Mar 2017 05:04:01 -0700 (PDT) X-Google-Original-Date: Tue, 28 Mar 2017 14:04 +0200 From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, roy.fan.zhang@intel.com, stable@dpdk.org Message-ID: <2019151.ZOXWie8io1@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20170328110448.GA22460@bricha3-MOBL3.ger.corp.intel.com> References: <20170328105816.22502-1-bruce.richardson@intel.com> <20170328110448.GA22460@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] crypto/scheduler: fix include of local headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Mar 2017 12:04:03 -0000 2017-03-28 12:04, Bruce Richardson: > On Tue, Mar 28, 2017 at 11:58:16AM +0100, Bruce Richardson wrote: > > When a C file for a library/driver is including the public header files for > > that library, those need to be included as local includes using quotes > > rather than angle-brackets. Without doing so, parallel builds can fail, as > > the compiler will only look for those headers in the global include folder > > rather than locally, and the build system does not enforce that the headers > > for a lib are installed before the rest of the lib is compiled. > > > > Fixes: 097ab0bac017 ("crypto/scheduler: add API") > > Fixes: 503e9c5afb38 ("crypto/scheduler: register as vdev driver") > > Fixes: 31439ee72b2c ("crypto/scheduler: add API implementations") > > > > CC: stable@dpdk.org > > Signed-off-by: Bruce Richardson > > --- > > drivers/crypto/scheduler/rte_cryptodev_scheduler.c | 2 +- > > drivers/crypto/scheduler/rte_cryptodev_scheduler.h | 2 +- > > drivers/crypto/scheduler/scheduler_pmd.c | 2 +- > > drivers/crypto/scheduler/scheduler_pmd_private.h | 2 +- > > 4 files changed, 4 insertions(+), 4 deletions(-) > > > Two follow-up points: > > * Even though this is a crypto patch, I think it should go in main tree > as builds are broken right now if you turn on the PMD and use a large > -j setting. (i.e. it's broken for me!! :-) ) Applied, thanks for catching > * Is there a reason why this PMD is disabled by default? It doesn't > appear to have any external dependencies and if we turn it on by > default we should be able to catch issues like this a lot quicker. I forgot to check this PMD. I was not compiling it either. I agree it should be enabled by default, or at least enabled in test-build.sh.