From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 597BD2C55 for ; Fri, 4 Aug 2017 00:39:51 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CF45820BCD; Thu, 3 Aug 2017 18:39:50 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 03 Aug 2017 18:39:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=cHJ4z0rfm0FS7y+ +ynRgnpiN8ar7450jczv+bDN0OEs=; b=SPmnRx+sTos8sd3oChAejR5Pe0ilDzw FmRxEQLtyt7/oWeXT60aR36hB/Q3XSM75S1Ewx1tmiSp8KmQSW3Egqx8Mekf3WyO NbKJ1vRmcFE2p5O5m+4K4eyie/89VGg8nhQOqXVo/Wh+X7YDgqgSw7wTx2S7Z2o4 eW2WT/m+CJ1o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=cHJ4z0rfm0FS7y++ynRgnpiN8ar7450jczv+bDN0OEs=; b=pdepS9j0 Mtymnc/Jkrgq48KpX/QUPu+L6VyB9FWfY30uYGhm8DdgTkRRzhdJOfqSS8Lvfkns N09GGwos73fDaFkX5VEtJzHEfL1+5FXFmHd5SdWvrAKj0RSqhZLw81c2nyTLdE+s ygTyJGGqnfFeL7HTP6U7ze/hX/CVcjXpBujr9vcttM0DvZ1F4Yv35gBCwA9VDMDL JnvQ5ZtQu+SYg8K7inQ0pL6suwaeq/y3Lp2Gxwe7dvBtB8fkOrlryqlQYZQM7G0H cuqww4yEuC3DmV1sOkufdoZRTsdFDrWyZK7aP4Dg8OQe5Cmbi2QKh7SJvmPubXOK R1+FAWTJhLunew== X-ME-Sender: X-Sasl-enc: pHGI4aRaHc5NfC1ESNJVOYy7j8o5c+g1WfVwXjxrwaVh 1501799990 Received: from xps.localnet (196.114.118.80.rev.sfr.net [80.118.114.196]) by mail.messagingengine.com (Postfix) with ESMTPA id 61B147E683; Thu, 3 Aug 2017 18:39:50 -0400 (EDT) From: Thomas Monjalon To: David Hunt Cc: dev@dpdk.org, shreyansh.jain@nxp.com Date: Fri, 04 Aug 2017 00:39:48 +0200 Message-ID: <2019184.UUXt4e9AVR@xps> In-Reply-To: <1496846277-280267-2-git-send-email-david.hunt@intel.com> References: <1495788764-37652-2-git-send-email-david.hunt@intel.com> <1496846277-280267-1-git-send-email-david.hunt@intel.com> <1496846277-280267-2-git-send-email-david.hunt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/3] mk: add sensible default target with defconfig X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2017 22:39:51 -0000 07/06/2017 16:37, David Hunt: > Users can now use 'make defconfig' to generate a configuration using > the most appropriate defaults for the current machine. > > > arch taken from uname -m > machine defaults to native > execenv is taken from uname, Linux=linuxapp, otherwise bsdapp > toolchain is taken from $CC -v to see which compiler to use > > Signed-off-by: David Hunt > Acked-by: Shreyansh Jain Looks to be a good idea if it is really automatic. > + ${CC} -v 2>&1 | \ > + grep " version " | cut -d ' ' -f 1) Unfortunately, it depends on $CC which is not commonly exported. What about defaulting to gcc? > - @echo "Configuration done" > + @echo "Configuration done using "$(shell basename \ > + $(RTE_CONFIG_TEMPLATE) | sed "s/defconfig_//g") RTE_CONFIG_TEMPLATE is not defined in this patch (and I do not see the benefit in next patch).