From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 25B9CA04A2;
Wed, 6 Nov 2019 11:44:10 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 8853A1C06A;
Wed, 6 Nov 2019 11:44:09 +0100 (CET)
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
[66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 99D0D1C066
for <dev@dpdk.org>; Wed, 6 Nov 2019 11:44:07 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 266F321B10;
Wed, 6 Nov 2019 05:44:06 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
by compute1.internal (MEProxy); Wed, 06 Nov 2019 05:44:06 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=mesmtp;
bh=Fp24Q4xb/stDcvmmodWDq5kQmHHI5tXwBjCZHuMZbuo=; b=PQbKyiPOu7eD
77MdsYVziYvPi3ZrGy48OUuUfAsx4rzKnYQSO0Eyaim7fFRRN0Gal+Sa8tLZhCAe
km/64MbJVlYV3xbce6+APw6AU5MmZmZ1zCQg2dAtF2QbjsRWEtGosM+dUO95knfE
B+p50EXwpFsSzJZs18tyrJBmB/NdLyU=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm1; bh=Fp24Q4xb/stDcvmmodWDq5kQmHHI5tXwBjCZHuMZb
uo=; b=W1ERkNehJBTe5Hzs8PR3lxmUbvwcJQ0K9g3IJp3v03k1Ky0w1WJOPuA/6
azp8Kc0Ehc6BqyScRgHVVYKzRl2JqDZyToh/u3etCm3lZGJ3JjCHpHDytVJNiOHo
gulU4z8QIZOE7JlIE66YmYfqBAxn0RgRTC+VfpXTdX8QP8ymYfoEM9LMKpt0Al5e
7C5KqFVysFHLRgDRbe6zmuQL1n5clzRFCGIDKm2bBVo+gRj7xC8zd3jAZPCqz9zk
RdeNyIFWLKTgu6fbpOt0q7dcXelyEW+WvTRfSkbGd4D2YCn0f1m1791/cpWS1SOH
9QpF3P9JtTTwiWg36u3G0U8+kZ57g==
X-ME-Sender: <xms:9aPCXQl90BcdTZ81TWaMnjKeusl41K9NY5l_WyOeU6SKcbxdGrlRog>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedruddujedgudelucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf
hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh
ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt
X-ME-Proxy: <xmx:9aPCXbWcNruN90i8GgI1pkuyZNdEV9S3p9NEQQ54BUnP6BTj6ERd4w>
<xmx:9aPCXVqau4OlIN7XiGXMsj03zwbTxgQqA5IMbfAxtrPLdwc5V9XHoA>
<xmx:9aPCXViaWnPTbX8kh9bIn4p_sfofZ3TZAwCQI3dFps4X3yTSqQRZOw>
<xmx:9qPCXQpPMFfULOP30_0Ph9nrWt7Eb4PwCh6xbZoQoc9wp-EO_A2Drw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id C690A80064;
Wed, 6 Nov 2019 05:44:04 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, Andrew Rybchenko <arybchenko@solarflare.com>,
Pallantla Poornima <pallantlax.poornima@intel.com>
Date: Wed, 06 Nov 2019 11:44:03 +0100
Message-ID: <2019215.qk59VCdi0P@xps>
In-Reply-To: <5949ceea-52d2-d32a-f944-a5c2c633239b@solarflare.com>
References: <20191104100622.13048-1-olivier.matz@6wind.com>
<5949ceea-52d2-d32a-f944-a5c2c633239b@solarflare.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] test/mempool: fix false positive test result
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
04/11/2019 13:42, Andrew Rybchenko:
> On 11/4/19 1:06 PM, Olivier Matz wrote:
> > The ret variable, initialized to -1, is changed to 0 during the test,
> > making the test successful in some cases where it should return a
> > failure.
> >
> > Fix this by always using the GOTO_ERR() macro that sets the ret
> > variable before doing the goto.
> >
> > Fixes: 923ceaeac140 ("test/mempool: add unit test cases")
> > Cc: Pallantla Poornima <pallantlax.poornima@intel.com>
> >
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
Applied, thanks