From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2664CA04F3; Thu, 2 Jan 2020 18:36:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 776A31C138; Thu, 2 Jan 2020 18:36:41 +0100 (CET) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 4DBFD1C137 for ; Thu, 2 Jan 2020 18:36:40 +0100 (CET) Received: by mail-pf1-f193.google.com with SMTP id q8so22339877pfh.7 for ; Thu, 02 Jan 2020 09:36:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hdtvsm0pZ4kPufgjw5nREFtLATgKGqfAFapm0vgvyGA=; b=jKmzkcI9zMGEjUWFNlpNhEoTc70DMzHFL1CT05LZl1K0T6xx60euQ/thA/ZM2WUFxZ uNor5m3J0mxxc3y9xTGgruNt56uOKvTmcYubY1G8nR/G4o1bTX1x6F0/Nyyduxh1vYjV OkhIGSsrJ3ZjuHqQjKDrcmnNrIjtxwc2iBLao0lqAXy0iuuG10RCqypSndBpUb9wGy4W qqclAYYpP1kPiZDYhQYkQ0w6lgYlsxYR0w+ExzvmG2i6z00Z+qzmsQtpeQpHjceSbSmk xOhrybGoLcXNYiWM+nfk7zjfl34dyDz1DSdUeWDcCDwkf1yyYeJhFJVpn55pyQEk2Id/ pN4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hdtvsm0pZ4kPufgjw5nREFtLATgKGqfAFapm0vgvyGA=; b=cefKu1sOaFvD4fRBOK/lDxSTOcR0USiQXblWhal/ld/e4CPuhxseFo6oC8RQHCKvlC SCnaP9NI/zKTLNWjbuhNMHxs/nHstIG1rkUgJuprW+lHOopbt8VC7P+qVfLfq3HgDd30 JBSpP1o035u9gW32q/gEeDTV/wkueKTPevYWSpQWKZayZmUlsnV26EjBP+SvbWCBNHFh N11/VBjmTUm/mMQGO4OfvDVRjtDzTAjVMAiP0/CcQASdZiFccPJmbcwgixdl3W+X5JRQ 9wFEJV8uHp4LFhRhgZDoP6SFtsMQdMJZyuhsAF/+p9sfq57KeWkPmdl98IVclYIRSGwe ciwg== X-Gm-Message-State: APjAAAWREc4CMQfTecRVmZbK8cSa2JleFD/NALtuUu+gdciwFAV2i39k CPgn5QxQ6BJVo5Nw6pLH2jobLw== X-Google-Smtp-Source: APXvYqx8bfozwxz7It9hdmAeZYJng9jgIKwuKb6pF9ukzsrYsi//tT0akceyTx9UQrd0rMCSfoeFwg== X-Received: by 2002:a62:1c95:: with SMTP id c143mr87140819pfc.219.1577986599311; Thu, 02 Jan 2020 09:36:39 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id d23sm63226408pfo.176.2020.01.02.09.36.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jan 2020 09:36:38 -0800 (PST) Date: Thu, 2 Jan 2020 09:36:30 -0800 From: Stephen Hemminger To: Haiyue Wang Cc: dev@dpdk.org, xiaolong.ye@intel.com Message-ID: <20200102093630.6811a8af@hermes.lan> In-Reply-To: <20200102071457.106137-1-haiyue.wang@intel.com> References: <20200102071457.106137-1-haiyue.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1] net/ice: align with MAC address length definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 2 Jan 2020 15:14:57 +0800 Haiyue Wang wrote: > Use the standand MAC address length definition in PMD's scope. > > Signed-off-by: Haiyue Wang > --- > drivers/net/ice/ice_ethdev.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c > index 2cbd82c94..80b422a27 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -873,7 +873,7 @@ ice_add_mac_filter(struct ice_vsi *vsi, struct rte_ether_addr *mac_addr) > ret = -ENOMEM; > goto DONE; > } > - rte_memcpy(&f->mac_info.mac_addr, mac_addr, ETH_ADDR_LEN); > + rte_memcpy(&f->mac_info.mac_addr, mac_addr, RTE_ETHER_ADDR_LEN); Please use rte_ether_addr_copy instead.