From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59ACFA04F3; Fri, 3 Jan 2020 08:49:15 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6E4E91C219; Fri, 3 Jan 2020 08:49:14 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 325031C02B; Fri, 3 Jan 2020 08:49:12 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jan 2020 23:49:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,389,1571727600"; d="scan'208";a="221577141" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga006.jf.intel.com with ESMTP; 02 Jan 2020 23:49:10 -0800 Date: Fri, 3 Jan 2020 15:43:40 +0800 From: Ye Xiaolong To: Andy Pei Cc: dev@dpdk.org, stable@dpdk.org, ferruh.yigit@intel.com, rosen.xu@intel.com Message-ID: <20200103074340.GL14498@intel.com> References: <1577775227-287186-1-git-send-email-andy.pei@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1577775227-287186-1-git-send-email-andy.pei@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/ipn3ke: fix line side statistics register read X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/31, Andy Pei wrote: >To read line side statistics register, eth_group_sel >args in function ipn3ke_indirect_mac_read should be 0. >When eth_group_sel is 1, the nic side register is read. > >Fixes: 5a6d883878db ("net/ipn3ke: implement statistics") >Cc: andy.pei@intel.com >Cc: stable@dpdk.org > >Signed-off-by: Andy Pei >--- >Cc: ferruh.yigit@intel.com >Cc: rosen.xu@intel.com >Cc: xiaolong.ye@intel.com > > drivers/net/ipn3ke/ipn3ke_representor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/net/ipn3ke/ipn3ke_representor.c b/drivers/net/ipn3ke/ipn3ke_representor.c >index 8d9ebef..80122e3 100644 >--- a/drivers/net/ipn3ke/ipn3ke_representor.c >+++ b/drivers/net/ipn3ke/ipn3ke_representor.c >@@ -701,7 +701,7 @@ struct ipn3ke_rpst_hw_port_stats *hw_stats) > &tmp, > IPN3KE_25G_TX_STATISTICS_STATUS, > port_id, >- 1); >+ 0); > if (tmp & IPN3KE_25G_TX_STATISTICS_STATUS_SHADOW_REQUEST_MASK) { > tmp = 0x00000000; > (*hw->f_mac_read)(hw, >-- >1.8.3.1 > Applied to dpdk-next-net-intel, Thanks.