DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-dev] [PATCH] testpmd: call cleanup on exit
Date: Tue,  7 Jan 2020 09:40:56 -0800	[thread overview]
Message-ID: <20200107174056.9397-1-stephen@networkplumber.org> (raw)

The rte_eal_cleanup code is not exercised by testpmd which
is the most used DPDK test tool. Add a call at end of program.

This helps exercise free and close paths which can
be checked with tools like valgrind.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 app/test-pmd/testpmd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index b3746822366f..a94ad19c8f5a 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -3570,5 +3570,6 @@ main(int argc, char** argv)
 			return 1;
 	}
 
+	rte_eal_cleanup();
 	return 0;
 }
-- 
2.20.1


             reply	other threads:[~2020-01-07 17:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-07 17:40 Stephen Hemminger [this message]
2020-01-07 17:58 ` Jerin Jacob
2020-01-07 18:59 ` [dpdk-dev] [PATCH v2] " Stephen Hemminger
2020-01-08  9:45   ` Iremonger, Bernard
2020-01-08 15:28     ` Stephen Hemminger
2020-01-09 11:16       ` Ferruh Yigit
2020-01-09 11:31         ` Ferruh Yigit
2020-01-09 16:13           ` Stephen Hemminger
2020-01-10  8:59             ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200107174056.9397-1-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).