From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1CABA04F3; Wed, 8 Jan 2020 16:28:29 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1B2351DA82; Wed, 8 Jan 2020 16:28:29 +0100 (CET) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 0A84C1DA80 for ; Wed, 8 Jan 2020 16:28:27 +0100 (CET) Received: by mail-pf1-f196.google.com with SMTP id 4so1793049pfz.9 for ; Wed, 08 Jan 2020 07:28:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=l1mCtHpSTVJvwi5eHV15AR7qxsMjOfCUpRETR3FbbA0=; b=mMIbcu9yC66nLFcxPxomVC3D6x0pOiPdVOzO+rM5Clk6iuidBlaavvByQKpxFgaqxo WRlUBCicTlJQKXjo1Q4k4uKC9EMlMPlhlrQFzXu4MDRSFRK5E7x3qVNJetYN9fCMKqm5 +83k9FtwFrYDogszN7BFcHmEa3ZLwBTSwnO2VHCzfQwDeOF6Vu7Uz8cq8CBUKdn6GzEw ilo7mGVYMWJnP689BTtiA6mphbQAanwO5G42aozMSrlBTfh4+Kzs7qGYZRkE5GuaEdsg 3Pv9uAH4jhVuf0TVvmAYCc0W08/QtIQLISZanY4bDpUDP4gtbBzHs8aXDEeC1nizGoQ3 cTEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=l1mCtHpSTVJvwi5eHV15AR7qxsMjOfCUpRETR3FbbA0=; b=RlFEA24MsKA7UFqG1HY1fFV6PFE2cQW2aBNZ0ik0w38CKvAt4ylBpGoTvgdkvjjcfA 0EWF5RplHdOmbeNMJhM361ZMgFImdnduuoDiQ+3nqGIz9H98vC5uOQPB413fG4WHOEVv qfLyFF44FTSEKTp3dFoM++FUwvHi9G2NVQtHohA1kpd/7OFcdeH6IZiqIpV3ZG+0P1p5 Br66NDU+DaITafHuksrlsR7XaUMttAT7jbEHTDHXgWOdmlfv49TQmU19PJPLKSrrXA8V +U6ybhg3z34YWwFvJfWKGlUjR6OXmQLxUzLg+Rt7UbpRECT93jJJLjBdgYJUuyqBDI2B VwoA== X-Gm-Message-State: APjAAAWd/6bts97BayIPcXcH8WD+jfx0gezVZjfitsjdjTT0kMwbRjfC 4sGZeMGquJmNrjbBoJ6GilXBeg== X-Google-Smtp-Source: APXvYqyCbn3ZM6184g281QUbJ9nYa3Tf2iYvdKHONuGb4UTio864G5soOrifA4wI0kV5PGvDUp5BFA== X-Received: by 2002:a62:b508:: with SMTP id y8mr5536664pfe.251.1578497306013; Wed, 08 Jan 2020 07:28:26 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id b8sm4200148pff.114.2020.01.08.07.28.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2020 07:28:25 -0800 (PST) Date: Wed, 8 Jan 2020 07:28:15 -0800 From: Stephen Hemminger To: "Iremonger, Bernard" Cc: "dev@dpdk.org" Message-ID: <20200108072815.69aeb7b0@hermes.lan> In-Reply-To: References: <20200107174056.9397-1-stephen@networkplumber.org> <20200107185942.21202-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] testpmd: call cleanup on exit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 8 Jan 2020 09:45:54 +0000 "Iremonger, Bernard" wrote: > Hi Stephen, > > > -----Original Message----- > > From: dev On Behalf Of Stephen Hemminger > > Sent: Tuesday, January 7, 2020 7:00 PM > > To: dev@dpdk.org > > Cc: Stephen Hemminger > > Subject: [dpdk-dev] [PATCH v2] testpmd: call cleanup on exit > > > > The rte_eal_cleanup code is not exercised by testpmd which is the most > > used DPDK test tool. Add a call at end of program. > > > > This helps exercise free and close paths which can be checked with tools like > > valgrind. > > > > Signed-off-by: Stephen Hemminger > > --- > > v2 - report errors > > > > app/test-pmd/testpmd.c | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > > b3746822366f..2eec8afda1ec 100644 > > --- a/app/test-pmd/testpmd.c > > +++ b/app/test-pmd/testpmd.c > > @@ -3570,5 +3570,10 @@ main(int argc, char** argv) > > return 1; > > } > > > > - return 0; > > + ret = rte_eal_cleanup(); > > + if (ret != 0) > > + rte_exit(EXIT_FAILURE, > > + "EAL cleanup failed: %s\n", strerror(-ret)); > > + > > + return EXIT_SUCCESS; > > } > > -- > > 2.20.1 > > This looks like a fix to me and is probably worth backporting, it should probably have a fixes line. > > Regards, > > Bernard. > Not sure if it needs to be backported. It depends on the definition of a fix. The original definition of stable was fixes only. Linux has moved on to fixes and backports of missing features like this; but DPDK has mostly stuck to the original definition of stable.