* [dpdk-dev] [PATCH] ci: pin meson to 0.52.0 @ 2020-01-08 11:02 David Marchand 2020-01-08 11:29 ` Luca Boccassi 0 siblings, 1 reply; 10+ messages in thread From: David Marchand @ 2020-01-08 11:02 UTC (permalink / raw) To: dev; +Cc: bruce.richardson, bluca, Aaron Conole, Michael Santana meson 0.53.0 has a compatibility issue [1] with the python 3.5.2 that comes in Ubuntu 16.04. Let's pin meson to 0.52.0 while the fix is being prepared in meson. 1: https://github.com/mesonbuild/meson/issues/6427 Signed-off-by: David Marchand <david.marchand@redhat.com> --- .ci/linux-setup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.ci/linux-setup.sh b/.ci/linux-setup.sh index dfb9d4a20..310873b3d 100755 --- a/.ci/linux-setup.sh +++ b/.ci/linux-setup.sh @@ -1,7 +1,7 @@ #!/bin/sh -xe # need to install as 'root' since some of the unit tests won't run without it -sudo python3 -m pip install --upgrade meson +sudo python3 -m pip install --upgrade meson==0.52 # setup hugepages cat /proc/meminfo -- 2.23.0 ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] ci: pin meson to 0.52.0 2020-01-08 11:02 [dpdk-dev] [PATCH] ci: pin meson to 0.52.0 David Marchand @ 2020-01-08 11:29 ` Luca Boccassi 2020-01-08 11:59 ` David Marchand 0 siblings, 1 reply; 10+ messages in thread From: Luca Boccassi @ 2020-01-08 11:29 UTC (permalink / raw) To: David Marchand, dev; +Cc: bruce.richardson, Aaron Conole, Michael Santana On Wed, 2020-01-08 at 12:02 +0100, David Marchand wrote: > meson 0.53.0 has a compatibility issue [1] with the python 3.5.2 that > comes > in Ubuntu 16.04. > Let's pin meson to 0.52.0 while the fix is being prepared in meson. > > 1: > https://github.com/mesonbuild/meson/issues/6427 > > > Signed-off-by: David Marchand < > david.marchand@redhat.com > > > --- > .ci/linux-setup.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Luca Boccassi <bluca@debian.org> -- Kind regards, Luca Boccassi ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] ci: pin meson to 0.52.0 2020-01-08 11:29 ` Luca Boccassi @ 2020-01-08 11:59 ` David Marchand 2020-01-08 12:10 ` Bruce Richardson 0 siblings, 1 reply; 10+ messages in thread From: David Marchand @ 2020-01-08 11:59 UTC (permalink / raw) To: Luca Boccassi; +Cc: dev, Bruce Richardson, Aaron Conole, Michael Santana On Wed, Jan 8, 2020 at 12:29 PM Luca Boccassi <bluca@debian.org> wrote: > > On Wed, 2020-01-08 at 12:02 +0100, David Marchand wrote: > > meson 0.53.0 has a compatibility issue [1] with the python 3.5.2 that > > comes > > in Ubuntu 16.04. > > Let's pin meson to 0.52.0 while the fix is being prepared in meson. > > > > 1: > > https://github.com/mesonbuild/meson/issues/6427 > > > > > > Signed-off-by: David Marchand < > > david.marchand@redhat.com > > > > > --- > > .ci/linux-setup.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Acked-by: Luca Boccassi <bluca@debian.org> There is a 0.52.1 version available, so I suppose we can blacklist meson < 0.53 instead. Thought? If noone objects, I will apply a fix by the end of the day. -- David Marchand ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] ci: pin meson to 0.52.0 2020-01-08 11:59 ` David Marchand @ 2020-01-08 12:10 ` Bruce Richardson 2020-01-08 14:22 ` David Marchand 0 siblings, 1 reply; 10+ messages in thread From: Bruce Richardson @ 2020-01-08 12:10 UTC (permalink / raw) To: David Marchand; +Cc: Luca Boccassi, dev, Aaron Conole, Michael Santana On Wed, Jan 08, 2020 at 12:59:35PM +0100, David Marchand wrote: > On Wed, Jan 8, 2020 at 12:29 PM Luca Boccassi <bluca@debian.org> wrote: > > > > On Wed, 2020-01-08 at 12:02 +0100, David Marchand wrote: > > > meson 0.53.0 has a compatibility issue [1] with the python 3.5.2 that > > > comes > > > in Ubuntu 16.04. > > > Let's pin meson to 0.52.0 while the fix is being prepared in meson. > > > > > > 1: > > > https://github.com/mesonbuild/meson/issues/6427 > > > > > > > > > Signed-off-by: David Marchand < > > > david.marchand@redhat.com > > > > > > > --- > > > .ci/linux-setup.sh | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Acked-by: Luca Boccassi <bluca@debian.org> > > There is a 0.52.1 version available, so I suppose we can blacklist > meson < 0.53 instead. > Thought? > > If noone objects, I will apply a fix by the end of the day. > Wondering if there is value in using 0.47.1, the minimum version we support, to catch potential issues with someone using features from newer versions? I suspect there are more people using the latest releases of meson than the baseline supported version? /Bruce ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] ci: pin meson to 0.52.0 2020-01-08 12:10 ` Bruce Richardson @ 2020-01-08 14:22 ` David Marchand 2020-01-08 15:10 ` Aaron Conole 2020-01-08 15:56 ` Kevin Traynor 0 siblings, 2 replies; 10+ messages in thread From: David Marchand @ 2020-01-08 14:22 UTC (permalink / raw) To: Bruce Richardson Cc: Luca Boccassi, dev, Aaron Conole, Michael Santana, Thomas Monjalon On Wed, Jan 8, 2020 at 1:10 PM Bruce Richardson <bruce.richardson@intel.com> wrote: > > On Wed, Jan 08, 2020 at 12:59:35PM +0100, David Marchand wrote: > > On Wed, Jan 8, 2020 at 12:29 PM Luca Boccassi <bluca@debian.org> wrote: > > > > > > On Wed, 2020-01-08 at 12:02 +0100, David Marchand wrote: > > > > meson 0.53.0 has a compatibility issue [1] with the python 3.5.2 that > > > > comes > > > > in Ubuntu 16.04. > > > > Let's pin meson to 0.52.0 while the fix is being prepared in meson. > > > > > > > > 1: > > > > https://github.com/mesonbuild/meson/issues/6427 > > > > > > > > > > > > Signed-off-by: David Marchand < > > > > david.marchand@redhat.com > > > > > > > > > --- > > > > .ci/linux-setup.sh | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > Acked-by: Luca Boccassi <bluca@debian.org> > > > > There is a 0.52.1 version available, so I suppose we can blacklist > > meson < 0.53 instead. > > Thought? > > > > If noone objects, I will apply a fix by the end of the day. > > > Wondering if there is value in using 0.47.1, the minimum version we > support, to catch potential issues with someone using features from newer > versions? I suspect there are more people using the latest releases of > meson than the baseline supported version? Testing with a fixed version seems better in a CI, and since we announce this minimum version, then yes, it makes sense. I will post a v2. -- David Marchand ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] ci: pin meson to 0.52.0 2020-01-08 14:22 ` David Marchand @ 2020-01-08 15:10 ` Aaron Conole 2020-01-08 15:50 ` Bruce Richardson 2020-01-08 15:56 ` Kevin Traynor 1 sibling, 1 reply; 10+ messages in thread From: Aaron Conole @ 2020-01-08 15:10 UTC (permalink / raw) To: David Marchand Cc: Bruce Richardson, Luca Boccassi, dev, Michael Santana, Thomas Monjalon David Marchand <david.marchand@redhat.com> writes: > On Wed, Jan 8, 2020 at 1:10 PM Bruce Richardson > <bruce.richardson@intel.com> wrote: >> >> On Wed, Jan 08, 2020 at 12:59:35PM +0100, David Marchand wrote: >> > On Wed, Jan 8, 2020 at 12:29 PM Luca Boccassi <bluca@debian.org> wrote: >> > > >> > > On Wed, 2020-01-08 at 12:02 +0100, David Marchand wrote: >> > > > meson 0.53.0 has a compatibility issue [1] with the python 3.5.2 that >> > > > comes >> > > > in Ubuntu 16.04. >> > > > Let's pin meson to 0.52.0 while the fix is being prepared in meson. >> > > > >> > > > 1: >> > > > https://github.com/mesonbuild/meson/issues/6427 >> > > > >> > > > >> > > > Signed-off-by: David Marchand < >> > > > david.marchand@redhat.com >> > > > > >> > > > --- >> > > > .ci/linux-setup.sh | 2 +- >> > > > 1 file changed, 1 insertion(+), 1 deletion(-) >> > > >> > > Acked-by: Luca Boccassi <bluca@debian.org> >> > >> > There is a 0.52.1 version available, so I suppose we can blacklist >> > meson < 0.53 instead. >> > Thought? >> > >> > If noone objects, I will apply a fix by the end of the day. >> > >> Wondering if there is value in using 0.47.1, the minimum version we >> support, to catch potential issues with someone using features from newer >> versions? I suspect there are more people using the latest releases of >> meson than the baseline supported version? > > Testing with a fixed version seems better in a CI, and since we > announce this minimum version, then yes, it makes sense. > I will post a v2. Why is 0.47.1 still the minimum? Don't we require features that are introduced as of 0.50? ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] ci: pin meson to 0.52.0 2020-01-08 15:10 ` Aaron Conole @ 2020-01-08 15:50 ` Bruce Richardson 2020-01-08 16:09 ` Aaron Conole 0 siblings, 1 reply; 10+ messages in thread From: Bruce Richardson @ 2020-01-08 15:50 UTC (permalink / raw) To: Aaron Conole Cc: David Marchand, Luca Boccassi, dev, Michael Santana, Thomas Monjalon On Wed, Jan 08, 2020 at 10:10:00AM -0500, Aaron Conole wrote: > David Marchand <david.marchand@redhat.com> writes: > > > On Wed, Jan 8, 2020 at 1:10 PM Bruce Richardson > > <bruce.richardson@intel.com> wrote: > >> > >> On Wed, Jan 08, 2020 at 12:59:35PM +0100, David Marchand wrote: > >> > On Wed, Jan 8, 2020 at 12:29 PM Luca Boccassi <bluca@debian.org> wrote: > >> > > > >> > > On Wed, 2020-01-08 at 12:02 +0100, David Marchand wrote: > >> > > > meson 0.53.0 has a compatibility issue [1] with the python 3.5.2 that > >> > > > comes > >> > > > in Ubuntu 16.04. > >> > > > Let's pin meson to 0.52.0 while the fix is being prepared in meson. > >> > > > > >> > > > 1: > >> > > > https://github.com/mesonbuild/meson/issues/6427 > >> > > > > >> > > > > >> > > > Signed-off-by: David Marchand < > >> > > > david.marchand@redhat.com > >> > > > > > >> > > > --- > >> > > > .ci/linux-setup.sh | 2 +- > >> > > > 1 file changed, 1 insertion(+), 1 deletion(-) > >> > > > >> > > Acked-by: Luca Boccassi <bluca@debian.org> > >> > > >> > There is a 0.52.1 version available, so I suppose we can blacklist > >> > meson < 0.53 instead. > >> > Thought? > >> > > >> > If noone objects, I will apply a fix by the end of the day. > >> > > >> Wondering if there is value in using 0.47.1, the minimum version we > >> support, to catch potential issues with someone using features from newer > >> versions? I suspect there are more people using the latest releases of > >> meson than the baseline supported version? > > > > Testing with a fixed version seems better in a CI, and since we > > announce this minimum version, then yes, it makes sense. > > I will post a v2. > > Why is 0.47.1 still the minimum? Don't we require features that are > introduced as of 0.50? > No, it should still work fine, and a quick sanity check tested with 0.47.1 on my system shows no issues, so I think we are good. There are some warnings printed about future features when you use a later version, but in all cases the extra parameters added are just ignored by the older versions, so compatiblity is maintained. Adding 0.47.1 to the CI will also help avoid any inadvertent new version requirements from sneaking in. /Bruce ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] ci: pin meson to 0.52.0 2020-01-08 15:50 ` Bruce Richardson @ 2020-01-08 16:09 ` Aaron Conole 2020-01-08 17:34 ` Bruce Richardson 0 siblings, 1 reply; 10+ messages in thread From: Aaron Conole @ 2020-01-08 16:09 UTC (permalink / raw) To: Bruce Richardson Cc: David Marchand, Luca Boccassi, dev, Michael Santana, Thomas Monjalon Bruce Richardson <bruce.richardson@intel.com> writes: > On Wed, Jan 08, 2020 at 10:10:00AM -0500, Aaron Conole wrote: >> David Marchand <david.marchand@redhat.com> writes: >> >> > On Wed, Jan 8, 2020 at 1:10 PM Bruce Richardson >> > <bruce.richardson@intel.com> wrote: >> >> >> >> On Wed, Jan 08, 2020 at 12:59:35PM +0100, David Marchand wrote: >> >> > On Wed, Jan 8, 2020 at 12:29 PM Luca Boccassi <bluca@debian.org> wrote: >> >> > > >> >> > > On Wed, 2020-01-08 at 12:02 +0100, David Marchand wrote: >> >> > > > meson 0.53.0 has a compatibility issue [1] with the python 3.5.2 that >> >> > > > comes >> >> > > > in Ubuntu 16.04. >> >> > > > Let's pin meson to 0.52.0 while the fix is being prepared in meson. >> >> > > > >> >> > > > 1: >> >> > > > https://github.com/mesonbuild/meson/issues/6427 >> >> > > > >> >> > > > >> >> > > > Signed-off-by: David Marchand < >> >> > > > david.marchand@redhat.com >> >> > > > > >> >> > > > --- >> >> > > > .ci/linux-setup.sh | 2 +- >> >> > > > 1 file changed, 1 insertion(+), 1 deletion(-) >> >> > > >> >> > > Acked-by: Luca Boccassi <bluca@debian.org> >> >> > >> >> > There is a 0.52.1 version available, so I suppose we can blacklist >> >> > meson < 0.53 instead. >> >> > Thought? >> >> > >> >> > If noone objects, I will apply a fix by the end of the day. >> >> > >> >> Wondering if there is value in using 0.47.1, the minimum version we >> >> support, to catch potential issues with someone using features from newer >> >> versions? I suspect there are more people using the latest releases of >> >> meson than the baseline supported version? >> > >> > Testing with a fixed version seems better in a CI, and since we >> > announce this minimum version, then yes, it makes sense. >> > I will post a v2. >> >> Why is 0.47.1 still the minimum? Don't we require features that are >> introduced as of 0.50? >> > No, it should still work fine, and a quick sanity check tested with 0.47.1 > on my system shows no issues, so I think we are good. > > There are some warnings printed about future features when you use a later > version, but in all cases the extra parameters added are just ignored by > the older versions, so compatiblity is maintained. Adding 0.47.1 to the CI > will also help avoid any inadvertent new version requirements from sneaking > in. Makes sense to me. Is there a way to make it whitelist the warnings we know about already? It would be nice to have the CI environment be warning-free (but I don't object to 0.47.1 being a minimum version or anything). > /Bruce ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] ci: pin meson to 0.52.0 2020-01-08 16:09 ` Aaron Conole @ 2020-01-08 17:34 ` Bruce Richardson 0 siblings, 0 replies; 10+ messages in thread From: Bruce Richardson @ 2020-01-08 17:34 UTC (permalink / raw) To: Aaron Conole Cc: David Marchand, Luca Boccassi, dev, Michael Santana, Thomas Monjalon On Wed, Jan 08, 2020 at 11:09:59AM -0500, Aaron Conole wrote: > Bruce Richardson <bruce.richardson@intel.com> writes: > > > On Wed, Jan 08, 2020 at 10:10:00AM -0500, Aaron Conole wrote: > >> David Marchand <david.marchand@redhat.com> writes: > >> > >> > On Wed, Jan 8, 2020 at 1:10 PM Bruce Richardson > >> > <bruce.richardson@intel.com> wrote: > >> >> > >> >> On Wed, Jan 08, 2020 at 12:59:35PM +0100, David Marchand wrote: > >> >> > On Wed, Jan 8, 2020 at 12:29 PM Luca Boccassi <bluca@debian.org> wrote: > >> >> > > > >> >> > > On Wed, 2020-01-08 at 12:02 +0100, David Marchand wrote: > >> >> > > > meson 0.53.0 has a compatibility issue [1] with the python 3.5.2 that > >> >> > > > comes > >> >> > > > in Ubuntu 16.04. > >> >> > > > Let's pin meson to 0.52.0 while the fix is being prepared in meson. > >> >> > > > > >> >> > > > 1: > >> >> > > > https://github.com/mesonbuild/meson/issues/6427 > >> >> > > > > >> >> > > > > >> >> > > > Signed-off-by: David Marchand < > >> >> > > > david.marchand@redhat.com > >> >> > > > > > >> >> > > > --- > >> >> > > > .ci/linux-setup.sh | 2 +- > >> >> > > > 1 file changed, 1 insertion(+), 1 deletion(-) > >> >> > > > >> >> > > Acked-by: Luca Boccassi <bluca@debian.org> > >> >> > > >> >> > There is a 0.52.1 version available, so I suppose we can blacklist > >> >> > meson < 0.53 instead. > >> >> > Thought? > >> >> > > >> >> > If noone objects, I will apply a fix by the end of the day. > >> >> > > >> >> Wondering if there is value in using 0.47.1, the minimum version we > >> >> support, to catch potential issues with someone using features from newer > >> >> versions? I suspect there are more people using the latest releases of > >> >> meson than the baseline supported version? > >> > > >> > Testing with a fixed version seems better in a CI, and since we > >> > announce this minimum version, then yes, it makes sense. > >> > I will post a v2. > >> > >> Why is 0.47.1 still the minimum? Don't we require features that are > >> introduced as of 0.50? > >> > > No, it should still work fine, and a quick sanity check tested with 0.47.1 > > on my system shows no issues, so I think we are good. > > > > There are some warnings printed about future features when you use a later > > version, but in all cases the extra parameters added are just ignored by > > the older versions, so compatiblity is maintained. Adding 0.47.1 to the CI > > will also help avoid any inadvertent new version requirements from sneaking > > in. > > Makes sense to me. Is there a way to make it whitelist the warnings we > know about already? It would be nice to have the CI environment be > warning-free (but I don't object to 0.47.1 being a minimum version or > anything). > I am currently working on reducing the number of meson warnings we have. Patchset I'd hope to get out tomorrow, with meson 0.52 shows only a single warning with doc builds disabled, and 2 with docs enabled. [That's reduced from 5 in both cases as it is now]. I'd hope to get the extra doc build warning removed if I have time in DPDK 20.02, but the final warning is about using meson's built-in warning options rather than our own flags, so I'm not even sure if we want to get rid of it. /Bruce ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] ci: pin meson to 0.52.0 2020-01-08 14:22 ` David Marchand 2020-01-08 15:10 ` Aaron Conole @ 2020-01-08 15:56 ` Kevin Traynor 1 sibling, 0 replies; 10+ messages in thread From: Kevin Traynor @ 2020-01-08 15:56 UTC (permalink / raw) To: David Marchand, Bruce Richardson Cc: Luca Boccassi, dev, Aaron Conole, Michael Santana, Thomas Monjalon On 08/01/2020 14:22, David Marchand wrote: > On Wed, Jan 8, 2020 at 1:10 PM Bruce Richardson > <bruce.richardson@intel.com> wrote: >> >> On Wed, Jan 08, 2020 at 12:59:35PM +0100, David Marchand wrote: >>> On Wed, Jan 8, 2020 at 12:29 PM Luca Boccassi <bluca@debian.org> wrote: >>>> >>>> On Wed, 2020-01-08 at 12:02 +0100, David Marchand wrote: >>>>> meson 0.53.0 has a compatibility issue [1] with the python 3.5.2 that >>>>> comes >>>>> in Ubuntu 16.04. >>>>> Let's pin meson to 0.52.0 while the fix is being prepared in meson. >>>>> >>>>> 1: >>>>> https://github.com/mesonbuild/meson/issues/6427 >>>>> >>>>> >>>>> Signed-off-by: David Marchand < >>>>> david.marchand@redhat.com >>>>>> >>>>> --- >>>>> .ci/linux-setup.sh | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> Acked-by: Luca Boccassi <bluca@debian.org> >>> >>> There is a 0.52.1 version available, so I suppose we can blacklist >>> meson < 0.53 instead. >>> Thought? >>> >>> If noone objects, I will apply a fix by the end of the day. >>> >> Wondering if there is value in using 0.47.1, the minimum version we >> support, to catch potential issues with someone using features from newer >> versions? I suspect there are more people using the latest releases of >> meson than the baseline supported version? > > Testing with a fixed version seems better in a CI, and since we > announce this minimum version, then yes, it makes sense. > I will post a v2. You can add a 'cc: stable' tag (in this case no fixes needed) as it is the same issue for the stable branches - though I will take it straight away. > > ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-01-08 17:34 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-01-08 11:02 [dpdk-dev] [PATCH] ci: pin meson to 0.52.0 David Marchand 2020-01-08 11:29 ` Luca Boccassi 2020-01-08 11:59 ` David Marchand 2020-01-08 12:10 ` Bruce Richardson 2020-01-08 14:22 ` David Marchand 2020-01-08 15:10 ` Aaron Conole 2020-01-08 15:50 ` Bruce Richardson 2020-01-08 16:09 ` Aaron Conole 2020-01-08 17:34 ` Bruce Richardson 2020-01-08 15:56 ` Kevin Traynor
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).