From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B0B8BA046B; Thu, 9 Jan 2020 17:14:19 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 23FDD1DE6F; Thu, 9 Jan 2020 17:14:19 +0100 (CET) Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by dpdk.org (Postfix) with ESMTP id CD9FC1DBB9 for ; Thu, 9 Jan 2020 17:14:17 +0100 (CET) Received: by mail-pl1-f193.google.com with SMTP id g6so2745820plp.6 for ; Thu, 09 Jan 2020 08:14:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xGrvFnlIqOKDP611hfL7A5P7SJj2UsYUh07WyIpn8j8=; b=S+uH1GLos1LX4+vB4oxTjBaZkBPLclSQv4j7AtMaWxoOIzOaPyC7gwrKy/3Z6PpDx1 ZBHba9uzU5H7dntiGrUY4txP1Gs6ieXCbZcaQb2QwTsk+O1jH729vzHhatcqK077jAw9 ibm67bwZUTyDFQ/ingDbllRDYWv+NnRxAFu9/gqSD80ui0Q1H8PBNCVv2MlkHMwJd2px 5JM7rqb9m4wVOZwJKYm3UyjyNi9/fClrQ9fUF7aKof5ZB33QOqjlsbsyUZZzlx1fjPaH 2kPZeR+6oMgXaMCut3yfmFHlQzfy6AB0VDBUBsoYpeOfEqF9oHouHlNVgm49c0G/BBZ0 /QoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xGrvFnlIqOKDP611hfL7A5P7SJj2UsYUh07WyIpn8j8=; b=n2AC/3w0cUsKiflVkENVZBrfwwybxudrn+lW/PPiqVkO02Fc0mhznG6f6nCxviuSs7 TCksnZf19Kn8qoEvyXd7EnUaG9VFdTrDEXpdNtawhCu856JS7nPyLQ3zCkgPLmzo1YY0 LiWVJevgcAPHMnXwszhU8nuZfUKq2jXusacrIOj3dFGsvCF2Ke8TameciBHxST54keYs R6K9eQysGiLIa+QIDfvC4VZRG3fZr7l2vA1IfG181pj2kprozPpU5jsmZruDrI6/pW64 +nw2gnEYHePBd75atdO8nOqnhS+IzFdp39TX6jXaDNTNhbKtxk0cp0o8MEZx851KtQQS 8yRg== X-Gm-Message-State: APjAAAWeI4x9tsqVYU7qzWc1DJ7jMP4LRp93ds6EMfCYT1OSoRgbovpl i+m4zwF9dBCmJ3hW1wjsbxGzGA== X-Google-Smtp-Source: APXvYqwFFsxVoQuQ4M9vt+qHaNFIXJBEv5F9HRAvlA217SgP68wo/TGWWpMVUqA7L9XZP36V9/S9uw== X-Received: by 2002:a17:902:9885:: with SMTP id s5mr12536945plp.217.1578586456855; Thu, 09 Jan 2020 08:14:16 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id b19sm8192212pfo.56.2020.01.09.08.14.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jan 2020 08:14:16 -0800 (PST) Date: Thu, 9 Jan 2020 08:13:48 -0800 From: Stephen Hemminger To: Ferruh Yigit Cc: "Iremonger, Bernard" , "dev@dpdk.org" Message-ID: <20200109081348.795ce272@hermes.lan> In-Reply-To: <9bb66700-e9d9-91aa-f53f-69d0e6510fc3@intel.com> References: <20200107174056.9397-1-stephen@networkplumber.org> <20200107185942.21202-1-stephen@networkplumber.org> <20200108072815.69aeb7b0@hermes.lan> <399a40ba-7643-f28f-ad76-3fc1e3d0ab9d@intel.com> <9bb66700-e9d9-91aa-f53f-69d0e6510fc3@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] testpmd: call cleanup on exit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 9 Jan 2020 11:31:30 +0000 Ferruh Yigit wrote: > On 1/9/2020 11:16 AM, Ferruh Yigit wrote: > > On 1/8/2020 3:28 PM, Stephen Hemminger wrote: > >> On Wed, 8 Jan 2020 09:45:54 +0000 > >> "Iremonger, Bernard" wrote: > >> > >>> Hi Stephen, > >>> > >>>> -----Original Message----- > >>>> From: dev On Behalf Of Stephen Hemminger > >>>> Sent: Tuesday, January 7, 2020 7:00 PM > >>>> To: dev@dpdk.org > >>>> Cc: Stephen Hemminger > >>>> Subject: [dpdk-dev] [PATCH v2] testpmd: call cleanup on exit > >>>> > >>>> The rte_eal_cleanup code is not exercised by testpmd which is the most > >>>> used DPDK test tool. Add a call at end of program. > >>>> > >>>> This helps exercise free and close paths which can be checked with tools like > >>>> valgrind. > >>>> > >>>> Signed-off-by: Stephen Hemminger > >>>> --- > >>>> v2 - report errors > >>>> > >>>> app/test-pmd/testpmd.c | 7 ++++++- > >>>> 1 file changed, 6 insertions(+), 1 deletion(-) > >>>> > >>>> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > >>>> b3746822366f..2eec8afda1ec 100644 > >>>> --- a/app/test-pmd/testpmd.c > >>>> +++ b/app/test-pmd/testpmd.c > >>>> @@ -3570,5 +3570,10 @@ main(int argc, char** argv) > >>>> return 1; > >>>> } > >>>> > >>>> - return 0; > >>>> + ret = rte_eal_cleanup(); > >>>> + if (ret != 0) > >>>> + rte_exit(EXIT_FAILURE, > >>>> + "EAL cleanup failed: %s\n", strerror(-ret)); > >>>> + > >>>> + return EXIT_SUCCESS; > >>>> } > >>>> -- > >>>> 2.20.1 > >>> > >>> This looks like a fix to me and is probably worth backporting, it should probably have a fixes line. > >>> > >>> Regards, > >>> > >>> Bernard. > >>> > >> > >> Not sure if it needs to be backported. It depends on the definition > >> of a fix. The original definition of stable was fixes only. > >> Linux has moved on to fixes and backports of missing features > >> like this; but DPDK has mostly stuck to the original definition > >> of stable. > >> > > > > I also tend to think this a fix more then a feature, and although it is a minor > > fix it is good to get it to reduce the change of the conflict on other stuff in > > LTS. I will add fix/stable tag while merging. > > > > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org > > Acked-by: Bernard Iremonger > > Applied to dpdk-next-net/master, thanks. Thanks, my concern about adding it to stable is that it might expose bugs in other places (like drivers). That is good for current release but not something stable users want to see.