From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8556BA046B; Thu, 9 Jan 2020 14:09:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 102DC1DD5D; Thu, 9 Jan 2020 14:09:11 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 01C4F1DD55; Thu, 9 Jan 2020 14:09:07 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2020 05:09:08 -0800 X-IronPort-AV: E=Sophos;i="5.69,413,1571727600"; d="scan'208";a="216296024" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.26]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 09 Jan 2020 05:09:04 -0800 Date: Thu, 9 Jan 2020 13:09:00 +0000 From: Bruce Richardson To: David Marchand Cc: dev@dpdk.org, bluca@debian.org, aconole@redhat.com, stable@dpdk.org, Thomas Monjalon , Ranjit Menon , Jeff Shaw , Pallavi Kadam , Harini Ramakrishnan , Anand Rawat Message-ID: <20200109130900.GB248@bricha3-MOBL.ger.corp.intel.com> References: <20200109125916.32073-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200109125916.32073-1-david.marchand@redhat.com> User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH 1/2] build: fix libm detection in meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jan 09, 2020 at 01:59:15PM +0100, David Marchand wrote: > Using version 0.47.1, meson is unable to find the math library in Travis > for the 32bits job. > Quite surprisingly, this problem is not seen with the 64bits jobs. > > Switching to 0.48.0, the problem disappears. > > But we should pass 'm' to find_library instead of 'libm' anyway. > > Fixes: 98edcbb5ab2f ("eal/windows: introduce Windows support") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > --- > config/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/config/meson.build b/config/meson.build > index 01911ecf9..28a57f56f 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -115,7 +115,7 @@ add_project_link_arguments('-pthread', language: 'c') > dpdk_extra_ldflags += '-pthread' > > # on some OS, maths functions are in a separate library > -if cc.find_library('libm', required : false).found() > +if cc.find_library('m', required : false).found() > # some libs depend on maths lib > add_project_link_arguments('-lm', language: 'c') > dpdk_extra_ldflags += '-lm' > -- > 2.23.0 Acked-by: Bruce Richardson