From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F425A04F9; Fri, 10 Jan 2020 10:15:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 162931E942; Fri, 10 Jan 2020 10:15:30 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 50BBD1E940 for ; Fri, 10 Jan 2020 10:15:28 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2020 01:15:26 -0800 X-IronPort-AV: E=Sophos;i="5.69,415,1571727600"; d="scan'208";a="223677487" Received: from bricha3-mobl.ger.corp.intel.com ([10.251.84.242]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 10 Jan 2020 01:15:25 -0800 Date: Fri, 10 Jan 2020 09:15:22 +0000 From: Bruce Richardson To: David Marchand Cc: "Mcnamara, John" , Luca Boccassi , dev , Aaron Conole , Thomas Monjalon Message-ID: <20200110091522.GA265@bricha3-MOBL.ger.corp.intel.com> References: <20200109115631.500056-1-bruce.richardson@intel.com> <20200109153112.501282-1-bruce.richardson@intel.com> <20200109153112.501282-6-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH v3 5/6] doc/guides: rebuild with meson whenever a file changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jan 09, 2020 at 07:06:31PM +0100, David Marchand wrote: > On Thu, Jan 9, 2020 at 7:03 PM David Marchand wrote: > > > > On Thu, Jan 9, 2020 at 4:31 PM Bruce Richardson > > wrote: > > > > > > Add proper support for calling sphinx whenever a file in the doc > > > directory changes. This is accomplished by using a wrapper script > > > for sphinx, which runs sphinx but also emits a gcc-format dependency > > > file listing all the doc files. This is used by ninja so that any > > > change to the doc files triggers a rebuild of the docs. > > > > > > Signed-off-by: Bruce Richardson > > > Acked-by: Aaron Conole > > > --- > > > buildtools/call-sphinx-build.py | 23 +++++++++++++++++++++++ > > > buildtools/meson.build | 6 ++++-- > > > doc/guides/meson.build | 22 ++++++++-------------- > > > 3 files changed, 35 insertions(+), 16 deletions(-) > > > create mode 100755 buildtools/call-sphinx-build.py > > > > This new file is not added to MAINTAINERS. > > I can fix this when applying. > I would add this to the section: > > Meson build > M: Bruce Richardson > Agreed.