From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1801A04F9; Fri, 10 Jan 2020 10:16:31 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A6D8A1E946; Fri, 10 Jan 2020 10:16:31 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id D78511E940; Fri, 10 Jan 2020 10:16:29 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2020 01:16:28 -0800 X-IronPort-AV: E=Sophos;i="5.69,415,1571727600"; d="scan'208";a="223677651" Received: from bricha3-mobl.ger.corp.intel.com ([10.251.84.242]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 10 Jan 2020 01:16:26 -0800 Date: Fri, 10 Jan 2020 09:16:23 +0000 From: Bruce Richardson To: David Marchand Cc: "Mcnamara, John" , Luca Boccassi , dev , Aaron Conole , Thomas Monjalon , stable@dpdk.org Message-ID: <20200110091623.GB265@bricha3-MOBL.ger.corp.intel.com> References: <20200109115631.500056-1-bruce.richardson@intel.com> <20200109153112.501282-1-bruce.richardson@intel.com> <20200109153112.501282-4-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH v3 3/6] doc/api: fix warning with meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jan 09, 2020 at 07:03:05PM +0100, David Marchand wrote: > On Thu, Jan 9, 2020 at 4:31 PM Bruce Richardson > wrote: > > > > The install parameter to configure_file is new in 0.50 and generates a > > warning since it is newer than our minimum version of 0.47.1. The > > parameter, however, is unneeded as the documentation states: > > > > "When omitted it defaults to true when install_dir is set and not empty, > > false otherwise." > > > > Given that install_dir is not set for this file, install defaults to false > > so no need to explicitly specify it. > > > > Fixes: 720b14db3ae2 ("build: generate API documentation with meson") > > Cc: stable@dpdk.org ? or does it depend on other changes? > I don't think it requires any other changes. Should probably go to 19.11 anyway - the 18.11 tree can skip it, I think.