From: Stephen Hemminger <stephen@networkplumber.org>
To: <jerinj@marvell.com>
Cc: <dev@dpdk.org>, <thomas@monjalon.net>, <olivier.matz@6wind.com>,
<arybchenko@solarflare.com>, <bruce.richardson@intel.com>,
<konstantin.ananyev@intel.com>, <hemant.agrawal@nxp.com>,
<shahafs@mellanox.com>, <honnappa.nagarahalli@arm.com>,
<gavin.hu@arm.com>, <viktorin@rehivetech.com>,
<drc@linux.vnet.ibm.com>, <anatoly.burakov@intel.com>,
<stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] mempool: fix mempool obj alignment for non x86
Date: Sat, 11 Jan 2020 09:41:47 -0800 [thread overview]
Message-ID: <20200111094147.35c1ea59@hermes.lan> (raw)
In-Reply-To: <20200111133410.2077135-1-jerinj@marvell.com>
On Sat, 11 Jan 2020 19:04:10 +0530
<jerinj@marvell.com> wrote:
> -#define MEMPOOL_F_NO_SPREAD 0x0001 /**< Do not spread among memory channels. */
> +#define MEMPOOL_F_NO_SPREAD 0x0001
> +/**< Do not spread among memory channels. It is a hint to the library,
> + * library honor this hint only when, if it is required by the
> + * (micro) architecture.
> + */
That text is awkward for me to read.
There maybe other reasons in future for mempool to ignore the flag.
I prefer the minor change original comment as:
> -#define MEMPOOL_F_NO_SPREAD 0x0001 /**< Spreading among memory channels not required. */
next prev parent reply other threads:[~2020-01-11 17:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 13:42 [dpdk-dev] [PATCH] " jerinj
2019-12-20 3:26 ` Gavin Hu
2019-12-20 3:45 ` Jerin Jacob
2019-12-20 10:54 ` [dpdk-dev] [PATCH] mempool: fix mempool obj alignment for nonx86 Morten Brørup
2019-12-20 15:55 ` [dpdk-dev] [PATCH] mempool: fix mempool obj alignment for non x86 Honnappa Nagarahalli
2019-12-20 16:55 ` Jerin Jacob
2019-12-20 21:07 ` Honnappa Nagarahalli
2019-12-21 5:06 ` Jerin Jacob
2019-12-27 15:54 ` Olivier Matz
2020-01-11 13:34 ` [dpdk-dev] [PATCH v2] " jerinj
2020-01-11 17:41 ` Stephen Hemminger [this message]
2020-01-13 6:49 ` [dpdk-dev] [PATCH v3] " jerinj
2020-01-13 9:46 ` [dpdk-dev] [dpdk-stable] " David Marchand
2020-01-13 11:46 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2020-01-14 21:06 ` [dpdk-dev] [PATCH v4] mempool: remove memory wastage on " jerinj
2020-01-16 13:10 ` Jerin Jacob
2020-01-20 12:24 ` Olivier Matz
2020-01-20 12:29 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200111094147.35c1ea59@hermes.lan \
--to=stephen@networkplumber.org \
--cc=anatoly.burakov@intel.com \
--cc=arybchenko@solarflare.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=gavin.hu@arm.com \
--cc=hemant.agrawal@nxp.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=jerinj@marvell.com \
--cc=konstantin.ananyev@intel.com \
--cc=olivier.matz@6wind.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).