DPDK patches and discussions
 help / color / mirror / Atom feed
From: Kalesh A P <kalesh-anakkur.purayil@broadcom.com>
To: dev@dpdk.org, ajit.khaparde@broadcom.com
Cc: ferruh.yigit@intel.com
Subject: [dpdk-dev] [PATCH 07/10] net/bnxt: fix a memory leak in port stop
Date: Mon, 13 Jan 2020 10:06:06 +0530	[thread overview]
Message-ID: <20200113043609.27363-8-kalesh-anakkur.purayil@broadcom.com> (raw)
In-Reply-To: <20200113043609.27363-1-kalesh-anakkur.purayil@broadcom.com>

From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>

The memory for mark table is allocated during port start.
But the allocated memory is freed only during port close
or driver unload which in turn causes a memory leakage
on each port start/stop.

Fixed it by moving the memory free to port stop.

Fixes: 4e40794a18a7 ("net/bnxt: add support for flow mark action")

Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
---
 drivers/net/bnxt/bnxt_ethdev.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 436ecbb..2661418 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -970,7 +970,10 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)
 	bnxt_int_handler(eth_dev);
 	bnxt_shutdown_nic(bp);
 	bnxt_hwrm_if_change(bp, 0);
-	memset(bp->mark_table, 0, BNXT_MARK_TABLE_SZ);
+
+	rte_free(bp->mark_table);
+	bp->mark_table = NULL;
+
 	bp->flags &= ~BNXT_FLAG_RX_VECTOR_PKT_MODE;
 	bp->dev_stopped = 1;
 	bp->rx_cosq_cnt = 0;
@@ -992,9 +995,6 @@ static void bnxt_dev_close_op(struct rte_eth_dev *eth_dev)
 		bp->grp_info = NULL;
 	}
 
-	rte_free(bp->mark_table);
-	bp->mark_table = NULL;
-
 	bnxt_dev_uninit(eth_dev);
 }
 
-- 
2.10.1


  parent reply	other threads:[~2020-01-13  4:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-13  4:35 [dpdk-dev] [PATCH 00/10] bnxt patch set with fixes Kalesh A P
2020-01-13  4:36 ` [dpdk-dev] [PATCH 01/10] net/bnxt: handle flow create failure Kalesh A P
2020-01-13  4:36 ` [dpdk-dev] [PATCH 02/10] net/bnxt: fix probe failure in FreeBSD Kalesh A P
2020-01-13  4:36 ` [dpdk-dev] [PATCH 03/10] net/bnxt: fix to use correct IOVA mapping Kalesh A P
2020-01-13  4:36 ` [dpdk-dev] [PATCH 04/10] net/bnxt: fix enable/disable VLAN filtering Kalesh A P
2020-01-13  4:36 ` [dpdk-dev] [PATCH 05/10] net/bnxt: fix enable/disable vlan strip Kalesh A P
2020-01-13  4:36 ` [dpdk-dev] [PATCH 06/10] net/bnxt: handle hw filter setting when port is stopped Kalesh A P
2020-01-13  4:36 ` Kalesh A P [this message]
2020-01-13  4:36 ` [dpdk-dev] [PATCH 08/10] net/bnxt: use macro for PCI log format Kalesh A P
2020-01-13  4:36 ` [dpdk-dev] [PATCH 09/10] net/bnxt: release port upon close Kalesh A P
2020-01-13  4:36 ` [dpdk-dev] [PATCH 10/10] net/bnxt: fix to cap max rings to minimum of compl rings and stat contexts Kalesh A P

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200113043609.27363-8-kalesh-anakkur.purayil@broadcom.com \
    --to=kalesh-anakkur.purayil@broadcom.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).