From: Fang TongHao <fangtonghao@sangfor.com.cn>
To: thomas@monjalon.net, ferruh.yigit@intel.com, arybchenko@solarflare.com
Cc: dev@dpdk.org, stable@dpdk.org, jia.guo@intel.com,
cunming.liang@intel.com, qi.z.zhang@intel.com,
jungle845943968@outlook.com,
Fang TongHao <fangtonghao@sangfor.com.cn>
Subject: [dpdk-dev] [PATCH v2] Fixes: ethdev: secondary process change shared memory
Date: Mon, 13 Jan 2020 13:03:12 +0800 [thread overview]
Message-ID: <20200113050312.1506-1-fangtonghao@sangfor.com.cn> (raw)
In-Reply-To: <20200109122710.1362-1-fangtonghao@sangfor.com.cn>
Secondary process calls “rte_eth_dev_pci_allocate”
function and enters rte_eth_copy_pci_info function
when initializing.Then it sets the value of struct
"rte_eth_dev_data.dev_flags" to zero and reset it,
but this struct is shared by primary process and
secondary process.To fix this bug,by adding an
if-statement to forbid the secondaryprocess changing
the above-mentioned value.
Signed-off-by: Fang TongHao <fangtonghao@sangfor.com.cn>
---
lib/librte_ethdev/rte_ethdev_pci.h | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/lib/librte_ethdev/rte_ethdev_pci.h b/lib/librte_ethdev/rte_ethdev_pci.h
index ccdbb46ec..e7dae0545 100644
--- a/lib/librte_ethdev/rte_ethdev_pci.h
+++ b/lib/librte_ethdev/rte_ethdev_pci.h
@@ -60,14 +60,16 @@ rte_eth_copy_pci_info(struct rte_eth_dev *eth_dev,
eth_dev->intr_handle = &pci_dev->intr_handle;
- eth_dev->data->dev_flags = 0;
- if (pci_dev->driver->drv_flags & RTE_PCI_DRV_INTR_LSC)
- eth_dev->data->dev_flags |= RTE_ETH_DEV_INTR_LSC;
- if (pci_dev->driver->drv_flags & RTE_PCI_DRV_INTR_RMV)
- eth_dev->data->dev_flags |= RTE_ETH_DEV_INTR_RMV;
-
- eth_dev->data->kdrv = pci_dev->kdrv;
- eth_dev->data->numa_node = pci_dev->device.numa_node;
+ if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
+ eth_dev->data->dev_flags = 0;
+ if (pci_dev->driver->drv_flags & RTE_PCI_DRV_INTR_LSC)
+ eth_dev->data->dev_flags |= RTE_ETH_DEV_INTR_LSC;
+ if (pci_dev->driver->drv_flags & RTE_PCI_DRV_INTR_RMV)
+ eth_dev->data->dev_flags |= RTE_ETH_DEV_INTR_RMV;
+
+ eth_dev->data->kdrv = pci_dev->kdrv;
+ eth_dev->data->numa_node = pci_dev->device.numa_node;
+ }
}
static inline int
--
2.24.1.windows.2
next prev parent reply other threads:[~2020-01-13 5:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 12:27 [dpdk-dev] [PATCH] ethdev: fix secondary process change share memory Fang TongHao
2020-01-10 7:30 ` Jeff Guo
2020-01-10 7:53 ` 方统浩50450
2020-01-13 5:03 ` Fang TongHao [this message]
2020-01-14 14:45 ` [dpdk-dev] [PATCH v2] Fixes: ethdev: secondary process change shared memory Ferruh Yigit
2020-01-15 6:49 ` 方统浩50450
2020-01-15 18:35 ` Ferruh Yigit
2020-01-15 20:43 ` Thomas Monjalon
2020-01-16 7:43 ` Andrew Rybchenko
2020-01-16 9:04 ` Ferruh Yigit
2020-01-16 11:35 ` 方统浩50450
2020-01-16 12:18 ` Ferruh Yigit
2020-01-17 2:11 ` 方统浩50450
2020-01-16 9:00 ` Ferruh Yigit
2020-01-17 2:08 ` [dpdk-dev] [PATCH v3] " Fang TongHao
2020-01-17 8:33 ` Andrew Rybchenko
2020-01-17 17:58 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200113050312.1506-1-fangtonghao@sangfor.com.cn \
--to=fangtonghao@sangfor.com.cn \
--cc=arybchenko@solarflare.com \
--cc=cunming.liang@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jia.guo@intel.com \
--cc=jungle845943968@outlook.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).