From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Xiao Wang <xiao.w.wang@intel.com>
Cc: qi.z.zhang@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/af_xdp: use single-prod-and-cons ring
Date: Tue, 14 Jan 2020 09:37:22 +0800 [thread overview]
Message-ID: <20200114013722.GD59121@intel.com> (raw)
In-Reply-To: <20200108133708.51909-1-xiao.w.wang@intel.com>
On 01/08, Xiao Wang wrote:
>The ring is used only by af_xdp pmd itself, so no need to support
>multi-producer and multi-consumer mode. This patch changes the ring
>to single-producer and single-consumer mode, which could yield better
>performance for addr enqueue and dequeue.
>
>Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
>---
> drivers/net/af_xdp/rte_eth_af_xdp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c
>index d903e6c28..683e2a559 100644
>--- a/drivers/net/af_xdp/rte_eth_af_xdp.c
>+++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
>@@ -809,7 +809,7 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals,
> umem->buf_ring = rte_ring_create(ring_name,
> ETH_AF_XDP_NUM_BUFFERS,
> rte_socket_id(),
>- 0x0);
>+ RING_F_SP_ENQ | RING_F_SC_DEQ);
> if (umem->buf_ring == NULL) {
> AF_XDP_LOG(ERR, "Failed to create rte_ring\n");
> goto err;
>--
>2.15.1
>
Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>
next prev parent reply other threads:[~2020-01-14 1:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 13:37 Xiao Wang
2020-01-13 10:05 ` Loftus, Ciara
2020-01-14 1:37 ` Ye Xiaolong [this message]
2020-01-14 9:38 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200114013722.GD59121@intel.com \
--to=xiaolong.ye@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).