From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 14EABA04FD; Tue, 14 Jan 2020 07:34:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 79A4D1C2A9; Tue, 14 Jan 2020 07:34:41 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id F13311C116 for ; Tue, 14 Jan 2020 07:34:39 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jan 2020 22:34:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,431,1571727600"; d="scan'208";a="256184630" Received: from intel.sh.intel.com ([10.239.255.129]) by fmsmga002.fm.intel.com with ESMTP; 13 Jan 2020 22:34:38 -0800 From: Lunyuan Cui To: dev@dpdk.org Cc: Qiming Yang , Lunyuan Cui Date: Tue, 14 Jan 2020 06:25:49 +0000 Message-Id: <20200114062549.29970-1-lunyuanx.cui@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200110083514.134541-1-lunyuanx.cui@intel.com> References: <20200110083514.134541-1-lunyuanx.cui@intel.com> Subject: [dpdk-dev] [PATCH v3] net/i40e: fix multi-queue Rx interrupt for VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The vector id bound to each queue could not large than the max usable vector. It will cause port start failed. This patch fixed this issue. And in this patch I changed judgement condition for the limit of vector id. vf->vf_res->max_vectors represents the number of usable vectors. It can effectively prevent vector id out of range. Fixes: 5b8d2d89dd99 (net/i40e: enable multi-queue Rx interrupt for VF) Signed-off-by: Lunyuan Cui --- v3: - Change commit message v2: - Change commit message --- drivers/net/i40e/i40e_ethdev_vf.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index 479f8282c..d514e8991 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c @@ -657,7 +657,6 @@ i40evf_config_irq_map(struct rte_eth_dev *dev) struct rte_intr_handle *intr_handle = &pci_dev->intr_handle; uint32_t vector_id; int i, err; - uint16_t nb_msix; if (dev->data->dev_conf.intr_conf.rxq != 0 && rte_intr_allow_others(intr_handle)) @@ -665,9 +664,6 @@ i40evf_config_irq_map(struct rte_eth_dev *dev) else vector_id = I40E_MISC_VEC_ID; - nb_msix = RTE_MIN(vf->vf_res->max_vectors, - intr_handle->nb_efd); - map_info = (struct virtchnl_irq_map_info *)cmd_buffer; map_info->num_vectors = dev->data->nb_rx_queues; for (i = 0; i < dev->data->nb_rx_queues; i++) { @@ -682,7 +678,7 @@ i40evf_config_irq_map(struct rte_eth_dev *dev) intr_handle->intr_vec[i] = vector_id; if (vector_id > I40E_MISC_VEC_ID) vector_id++; - if (vector_id > nb_msix) + if (vector_id >= vf->vf_res->max_vectors) vector_id = I40E_RX_VEC_START; } -- 2.17.1