From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 463D6A0512; Tue, 14 Jan 2020 18:36:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6E1EA1BFA5; Tue, 14 Jan 2020 18:36:02 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 1349B1BF82 for ; Tue, 14 Jan 2020 18:35:59 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jan 2020 09:35:59 -0800 X-IronPort-AV: E=Sophos;i="5.70,319,1574150400"; d="scan'208";a="397584910" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.26]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 14 Jan 2020 09:35:57 -0800 Date: Tue, 14 Jan 2020 17:35:54 +0000 From: Bruce Richardson To: Luca Boccassi Cc: David Marchand , "Mcnamara, John" , dev , Aaron Conole , Thomas Monjalon Message-ID: <20200114173554.GC1660@bricha3-MOBL.ger.corp.intel.com> References: <20200109115631.500056-1-bruce.richardson@intel.com> <20200110215205.513185-1-bruce.richardson@intel.com> <20200114161923.GB1660@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH v4 0/6] meson build improvements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jan 14, 2020 at 04:35:09PM +0000, Luca Boccassi wrote: > On Tue, 2020-01-14 at 16:19 +0000, Bruce Richardson wrote: > > On Tue, Jan 14, 2020 at 05:00:17PM +0100, David Marchand wrote: > > > On Fri, Jan 10, 2020 at 10:52 PM Bruce Richardson > > > < > > > bruce.richardson@intel.com > > > > wrote: > > > > These patches make some improvements to the meson build, > > > > particularly > > > > for documentation. They also remove many, but not all warnings > > > > issued > > > > by meson e.g. warnings about newer features unsupported in > > > > baseline. > > > > > > > > The biggest change is to improve the handling of the guide html > > > > docs. > > > > The change here is more significant, and the doc build now uses a > > > > wrapper script around sphinx. This wrapper script allows us to > > > > output > > > > correct dependency information for the sphinx build in a .d file. > > > > This > > > > .d file is processed by ninja (not meson) on build, so that any > > > > changes > > > > to doc files trigger a rebuild to the guides using sphinx. > > > > > > > > For now, the two patches which remove the meson version warnings > > > > are > > > > CC'ed to stable for backport, theoretically this who set could be > > > > backported if so desired, as all changes could be considered > > > > fixes to > > > > some degree or other, and nothing introduces a whole new feature. > > > > > > > > Note: for completeness and simplicity, previously submitted patch > > > > http://patches.dpdk.org/patch/64189/ > > > > is included in this set, and will > > > > be marked superceded in patchwork. > > > > > > > > V4: fix build with older sphinx > > > > > > > > V3: Shorten the python code in patch 5, and ensure style > > > > compliance as > > > > flagged by Aaron. > > > > > > > > V2: resend to correct email addresses > > > > > > Tried this series in Travis. It went fine through my own checks > > > too. > > > > > > But OBS is not happy with Debian 10, Debian Next and Ubuntu >= > > > 18.04. > > > The packaging fails when ninja can't find the 'doc' target. > > > > > > > Can you send on a link to the failure logs? > > > > I suspect this may be due to returning early from the doc folder if > > the > > document building is disabled (but need to see logs to confirm). > > However, > > I'm not sure it makes sense to have a doc target defined if doc > > building is > > disabled in build config. > > Sorry, should have thought about this when reviewing: the usefulness of > having the target work without the option set is that the docs will > only be built when called explicitly, without having to change the > configuration. > > Given the doc build is very slow and it's arch-independent, in > Debian/Ubuntu we only do it once, in the arch-independent target (arch: > all). > Right. I think the offending patch #2, can just be dropped from the set. /Bruce