From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A06CDA04FD; Wed, 15 Jan 2020 11:17:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4321C1C031; Wed, 15 Jan 2020 11:17:56 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id B2F011BF81 for ; Wed, 15 Jan 2020 11:17:54 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jan 2020 02:17:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,322,1574150400"; d="scan'208";a="248367533" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by fmsmga004.fm.intel.com with ESMTP; 15 Jan 2020 02:17:52 -0800 Date: Wed, 15 Jan 2020 18:17:45 +0800 From: Ye Xiaolong To: Ferruh Yigit Cc: Wenzhuo Lu , Konstantin Ananyev , Phil Yang , Gavin Hu , Dharmik Thakkar , dev@dpdk.org, Maxime Coquelin Message-ID: <20200115101745.GF33538@intel.com> References: <20200114175247.2930261-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200114175247.2930261-1-ferruh.yigit@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix build for gcc 4.8.5 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 01/14, Ferruh Yigit wrote: >Build error: > In function ‘ixgbe_recv_pkts_lro_bulk_alloc’: >../drivers/net/ixgbe/ixgbe_rxtx.c:2209:24: > error: ‘next_sc_entry’ may be used uninitialized in this function > [-Werror=maybe-uninitialized] > next_sc_entry->fbuf = first_seg; > ^ >http://mails.dpdk.org/archives/test-report/2020-January/113891.html > >This is a compiler false positive and error not seen by newer compilers, >or clang but to fix the warning initializing the complained variable. > >According git bisect, no idea how: >Fixes: 8a2e7ce976fd ("net/ixgbe: avoid multiple definitions of bool") > >Reported-by: Maxime Coquelin >Signed-off-by: Ferruh Yigit >--- >Cc: dharmik.thakkar@arm.com >--- > drivers/net/ixgbe/ixgbe_rxtx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c >index 13b06eb9c..30f890572 100644 >--- a/drivers/net/ixgbe/ixgbe_rxtx.c >+++ b/drivers/net/ixgbe/ixgbe_rxtx.c >@@ -2028,7 +2028,7 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts, > bool eop; > struct ixgbe_rx_entry *rxe; > struct ixgbe_scattered_rx_entry *sc_entry; >- struct ixgbe_scattered_rx_entry *next_sc_entry; >+ struct ixgbe_scattered_rx_entry *next_sc_entry = NULL; > struct ixgbe_rx_entry *next_rxe = NULL; > struct rte_mbuf *first_seg; > struct rte_mbuf *rxm; >-- >2.24.1 > Acked-by: Xiaolong Ye