* [dpdk-dev] [PATCH] examples/l2fwd-crypto:skip dev configure for masked devices
@ 2020-01-16 7:43 Apeksha Gupta
2020-01-28 6:12 ` Akhil Goyal
0 siblings, 1 reply; 3+ messages in thread
From: Apeksha Gupta @ 2020-01-16 7:43 UTC (permalink / raw)
To: akhil.goyal; +Cc: thomas, dev, Apeksha Gupta, stable
The devices which are masked by cryptodev mask should not be initialized
and skipped while traversing the device list.
Fixes: 61a7018ba0 ("examples/l2fwd-crypto:skip dev configure for masked devices")
Cc: stable@dpdk.org
Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>
---
examples/l2fwd-crypto/main.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c
index 9b3aa6d07..df48d180a 100644
--- a/examples/l2fwd-crypto/main.c
+++ b/examples/l2fwd-crypto/main.c
@@ -2294,6 +2294,12 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports,
struct rte_cryptodev_qp_conf qp_conf;
struct rte_cryptodev_info dev_info;
+ if (check_cryptodev_mask(options, cdev_id) < 0)
+ continue;
+
+ if (check_capabilities(options, cdev_id) < 0)
+ continue;
+
retval = rte_cryptodev_socket_id(cdev_id);
if (retval < 0) {
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto:skip dev configure for masked devices
2020-01-16 7:43 [dpdk-dev] [PATCH] examples/l2fwd-crypto:skip dev configure for masked devices Apeksha Gupta
@ 2020-01-28 6:12 ` Akhil Goyal
2020-02-04 13:38 ` Akhil Goyal
0 siblings, 1 reply; 3+ messages in thread
From: Akhil Goyal @ 2020-01-28 6:12 UTC (permalink / raw)
To: Apeksha Gupta; +Cc: thomas, dev, Apeksha Gupta, stable
>
> The devices which are masked by cryptodev mask should not be initialized
> and skipped while traversing the device list.
>
> Fixes: 61a7018ba0 ("examples/l2fwd-crypto:skip dev configure for masked
> devices")
> Cc: stable@dpdk.org
>
> Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>
> ---
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Applied to dpdk-next-crypto
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto:skip dev configure for masked devices
2020-01-28 6:12 ` Akhil Goyal
@ 2020-02-04 13:38 ` Akhil Goyal
0 siblings, 0 replies; 3+ messages in thread
From: Akhil Goyal @ 2020-02-04 13:38 UTC (permalink / raw)
To: Akhil Goyal, Apeksha Gupta; +Cc: thomas, dev, Apeksha Gupta, stable
>
>
> >
> > The devices which are masked by cryptodev mask should not be initialized
> > and skipped while traversing the device list.
> >
> > Fixes: 61a7018ba0 ("examples/l2fwd-crypto:skip dev configure for masked
> > devices")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>
> > ---
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
>
> Applied to dpdk-next-crypto
>
This patch is taken back. It is not fixing the issue properly.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-04 13:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-16 7:43 [dpdk-dev] [PATCH] examples/l2fwd-crypto:skip dev configure for masked devices Apeksha Gupta
2020-01-28 6:12 ` Akhil Goyal
2020-02-04 13:38 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).