* [dpdk-dev] [PATCH] net/dpaa: fix Rx offload flags on jumbo MTU set
@ 2020-01-16 7:56 Apeksha Gupta
2020-01-16 20:19 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Apeksha Gupta @ 2020-01-16 7:56 UTC (permalink / raw)
To: ferruh.yigit; +Cc: thomas, dev, Apeksha Gupta
The JUMBO frame handling in dpaa_dev_mtu_set api was not correct.
When frame_size is greater than RTE_ETHER_MAX_LEN, the
intention is to add JUMBO flag in rx offload while it was resetting
all other flags other than JUMBO as AND operator was used instead of OR.
Fixes: 0ebce6129bc6 ("net/dpaa: support new ethdev offload APIs")
Cc :stable@dpdk.org
Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>
---
drivers/net/dpaa/dpaa_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c
index b4558eb71..f4974eb92 100644
--- a/drivers/net/dpaa/dpaa_ethdev.c
+++ b/drivers/net/dpaa/dpaa_ethdev.c
@@ -178,7 +178,7 @@ dpaa_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
}
if (frame_size > RTE_ETHER_MAX_LEN)
- dev->data->dev_conf.rxmode.offloads &=
+ dev->data->dev_conf.rxmode.offloads |=
DEV_RX_OFFLOAD_JUMBO_FRAME;
else
dev->data->dev_conf.rxmode.offloads &=
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/dpaa: fix Rx offload flags on jumbo MTU set
2020-01-16 7:56 [dpdk-dev] [PATCH] net/dpaa: fix Rx offload flags on jumbo MTU set Apeksha Gupta
@ 2020-01-16 20:19 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2020-01-16 20:19 UTC (permalink / raw)
To: Apeksha Gupta; +Cc: thomas, dev
On 1/16/2020 7:56 AM, Apeksha Gupta wrote:
> The JUMBO frame handling in dpaa_dev_mtu_set api was not correct.
> When frame_size is greater than RTE_ETHER_MAX_LEN, the
> intention is to add JUMBO flag in rx offload while it was resetting
> all other flags other than JUMBO as AND operator was used instead of OR.
>
> Fixes: 0ebce6129bc6 ("net/dpaa: support new ethdev offload APIs")
> Cc :stable@dpdk.org
>
> Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-16 20:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-16 7:56 [dpdk-dev] [PATCH] net/dpaa: fix Rx offload flags on jumbo MTU set Apeksha Gupta
2020-01-16 20:19 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).