From: Stephen Hemminger <stephen@networkplumber.org>
To: <dave@barachs.net>
Cc: "'Ray Kinsella'" <mdr@ashroe.eu>,
"'Jerin Jacob Kollanukkaran'" <jerinj@marvell.com>,
"'dpdk-dev'" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC] DPDK Trace support
Date: Mon, 20 Jan 2020 08:51:40 -0800 [thread overview]
Message-ID: <20200120085140.7f6988c3@hermes.lan> (raw)
In-Reply-To: <011001d5ce11$fc804bd0$f580e370$@barachs.net>
On Sat, 18 Jan 2020 10:14:31 -0500
<dave@barachs.net> wrote:
> It would be well worth considering one of the vpp techniques to minimize trace impact:
>
> static inline ring_handler_inline (..., int is_traced)
> {
> for (i = 0; i < vector_size; i++)
> {
> if (is_traced)
> {
> do_trace_work;
> }
> normal_packet_processing;
> }
> }
>
> ring_handler (...)
> {
> if (PREDICT_FALSE(global_trace_flag != 0))
> return ring_handler_inline (..., 1 /* is_traced */);
> else
> return ring_handler_inline (..., 0 /* is_traced */);
> }
>
> This reduces the runtime tax to the absolute minimum, but costs space.
>
> Please consider it.
>
> HTH... Dave
LTTng already has tracepoint_enabled for this
next prev parent reply other threads:[~2020-01-20 16:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 10:40 Jerin Jacob Kollanukkaran
2020-01-13 11:00 ` Ray Kinsella
2020-01-13 12:04 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2020-01-18 15:14 ` [dpdk-dev] " dave
2020-01-20 16:51 ` Stephen Hemminger [this message]
2020-01-13 13:05 ` Bruce Richardson
2020-01-13 14:46 ` Jerin Jacob
2020-01-13 14:58 ` Bruce Richardson
2020-01-13 15:13 ` Jerin Jacob
2020-01-13 16:12 ` Bruce Richardson
2020-01-17 4:41 ` Jerin Jacob
2020-01-17 8:04 ` David Marchand
2020-01-17 9:52 ` Jerin Jacob
2020-01-17 10:30 ` Mattias Rönnblom
2020-01-17 10:54 ` Jerin Jacob
2020-02-15 10:21 ` Jerin Jacob
2020-02-17 9:35 ` Mattias Rönnblom
2020-02-17 10:23 ` Jerin Jacob
2020-01-17 10:43 ` David Marchand
2020-01-17 11:08 ` Jerin Jacob
2020-01-27 16:12 ` Aaron Conole
2020-01-27 17:23 ` Jerin Jacob
2020-01-20 4:48 Jerin Jacob Kollanukkaran
2020-01-20 12:08 ` Ray Kinsella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120085140.7f6988c3@hermes.lan \
--to=stephen@networkplumber.org \
--cc=dave@barachs.net \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=mdr@ashroe.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).