From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 55A4AA051F;
	Mon, 20 Jan 2020 17:51:52 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id D9EE31BEA5;
	Mon, 20 Jan 2020 17:51:50 +0100 (CET)
Received: from mail-pj1-f67.google.com (mail-pj1-f67.google.com
 [209.85.216.67]) by dpdk.org (Postfix) with ESMTP id CABEE1BE94
 for <dev@dpdk.org>; Mon, 20 Jan 2020 17:51:49 +0100 (CET)
Received: by mail-pj1-f67.google.com with SMTP id d15so12984pjw.1
 for <dev@dpdk.org>; Mon, 20 Jan 2020 08:51:49 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=Qlf2B7+yRe8ZX18UuX18zDoqg18+uS4LxfV17p9aNwQ=;
 b=DaqdNcV+9OLuQJNNzwRdBuUhpxNtMHQjKspOAj9L5Az1WAQsB6H4EKtrsInRebTgCa
 z2TNr+q5g5QXNv++geqZOXh4h5fLOpNToscCKsF7jQpJ2yM6RpVisLCSB2eEkzSPS0Hv
 Kr04VkPTvxNox1LLDpiedq5MLxzMqAhroH+T7l+S+mT2R+FbZuebQPMyupwazreL3DJj
 7N4oBEr95A3P0oeSDfopLMZi5zqXbNkypsJ/ZFYjrtJqXtex02i+1OFE6PYkeiwhVBmb
 jxFpemOlu1TMGMfto6pd4jggdo47w2ysOpY4Cw5tgwruMYwmH65UxvtRsBTxSCon3Aqr
 BynQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=Qlf2B7+yRe8ZX18UuX18zDoqg18+uS4LxfV17p9aNwQ=;
 b=tRJqICNo/R605QrsnlJPYR+Txec37T60SaiCkpkk2ZWbdEaiRh8jnkhv+oSmSHdsa0
 Nk0qFA7sMnarl1EwK1hZEh1nGCyfYYBwCo901dZQSJxBIPGxb/KlLl8o1eJsv3GdLHcW
 G5U5dYhkUdtJVfvXYZfqgCJKiCU8HVMCZdYX2RYHdyNKPjj0o3iqJcT2pqXTgazOPH0I
 SdlgexclsDfpwkXzh2Qa6dwLh74hGB2CF2VDzOt5MHiXOj41y/OVkCIBd4PgLgs4vRms
 wD0j0xTVDsrtyHbbeplvkFaTwF5Ewd/JxZvuSNGlmmNh0Tz4dOWJ8kTkFVax43rLgdkn
 Uh9g==
X-Gm-Message-State: APjAAAWviMJAwsgEOz75pkFhw9F/w3YYjKcvR5mLnVjVUzd4oTSsky5v
 woCUANCvRdFAMQVyWWdPBAj2jA==
X-Google-Smtp-Source: APXvYqwpWqgqB2O3RkjQzdS0deVqN1lpRF93B9Wea9ffXxWhOzwSjtTcY6Itp5DG2yqIO3wcDPCGKA==
X-Received: by 2002:a17:90a:6484:: with SMTP id h4mr536634pjj.84.1579539108935; 
 Mon, 20 Jan 2020 08:51:48 -0800 (PST)
Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])
 by smtp.gmail.com with ESMTPSA id g26sm39953893pfo.130.2020.01.20.08.51.48
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 20 Jan 2020 08:51:48 -0800 (PST)
Date: Mon, 20 Jan 2020 08:51:40 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: <dave@barachs.net>
Cc: "'Ray Kinsella'" <mdr@ashroe.eu>, "'Jerin Jacob Kollanukkaran'"
 <jerinj@marvell.com>, "'dpdk-dev'" <dev@dpdk.org>
Message-ID: <20200120085140.7f6988c3@hermes.lan>
In-Reply-To: <011001d5ce11$fc804bd0$f580e370$@barachs.net>
References: <BYAPR18MB2424BF2CAD9AFE5F1C3755F0C8350@BYAPR18MB2424.namprd18.prod.outlook.com>
 <d4977e85-d612-f4bd-63d2-4d98895b3335@ashroe.eu>
 <011001d5ce11$fc804bd0$f580e370$@barachs.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [RFC]  DPDK Trace support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sat, 18 Jan 2020 10:14:31 -0500
<dave@barachs.net> wrote:

> It would be well worth considering one of the vpp techniques to minimize trace impact:
> 
> static inline ring_handler_inline (..., int is_traced)
> {
>   for (i = 0; i < vector_size; i++)
>     {
>       if (is_traced)
> 	{
> 	  do_trace_work;
> 	}
>       normal_packet_processing;
>     }
> }
> 
> ring_handler (...)
> {
>   if (PREDICT_FALSE(global_trace_flag != 0))
>     return ring_handler_inline (..., 1 /* is_traced */);
>   else
>     return ring_handler_inline (..., 0 /* is_traced */);
> }
> 
> This reduces the runtime tax to the absolute minimum, but costs space. 
> 
> Please consider it.
> 
> HTH... Dave

LTTng already has tracepoint_enabled for this