Re: [dpdk-dev] [PATCH v2] build: allow using wildcards to disable drivers

[Robin Jarry <robin.jarry@6wind.com>]

2020-01-21, Bruce Richardson:
> > > +from glob import iglob # glob iterator
> > 
> > No need to make it explicit. People can read the description in the
> > official docs.
> 
> Except the fact that you yourself mistook it for a case-insensitive glob
> implies that a comment is needed! :-)

The fact that I should check things before I make comments should not
force people to add comments next to imports :-)

> This is script is to be called from the build system. I'm not worried about
> incorrect numbers of args, and argparse itself seems overkill. I'll add a
> check to print an error if len(argv) != 1.

Fair enough. However, argparse is never overkill. Using it is not going
to slow down your script.

> Just keeping the code short. I actually had originally got the print join
> in the same line as the list comprehension but that even I felt was a bit
> unreadable - even if it did leave a nice short script!

This is not perl^Wa competition :-)

-- 
Robin