From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D62DAA0525; Wed, 22 Jan 2020 08:49:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B4BE82B98; Wed, 22 Jan 2020 08:49:40 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 9EF272B98 for ; Wed, 22 Jan 2020 08:49:39 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jan 2020 23:49:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,348,1574150400"; d="scan'208";a="221956240" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by fmsmga008.fm.intel.com with ESMTP; 21 Jan 2020 23:49:37 -0800 Date: Wed, 22 Jan 2020 15:49:13 +0800 From: Ye Xiaolong To: "Xing, Beilei" Cc: "Zhang, Qi Z" , "dev@dpdk.org" Message-ID: <20200122074913.GB41361@intel.com> References: <20200122035810.154767-1-xiaolong.ye@intel.com> <94479800C636CB44BD422CB454846E013CECFDA5@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <94479800C636CB44BD422CB454846E013CECFDA5@SHSMSX101.ccr.corp.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/i40e/base: skip further adminq init for VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 01/22, Xing, Beilei wrote: > > >> -----Original Message----- >> From: Ye, Xiaolong >> Sent: Wednesday, January 22, 2020 11:58 AM >> To: Xing, Beilei ; Zhang, Qi Z >> Cc: dev@dpdk.org; Ye, Xiaolong >> Subject: [PATCH] net/i40e/base: skip further adminq init for VF >> >> Since VF has no need of firmware, we can skip further adminq init which >> involves firmware operation, this patch fixes the testpmd segfault issue when >> starting with i40e VF. >> >> Fixes: d5e1a149362e ("net/i40e/base: check MAC type") >> >> Signed-off-by: Xiaolong Ye >> --- >> drivers/net/i40e/base/i40e_adminq.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/net/i40e/base/i40e_adminq.c >> b/drivers/net/i40e/base/i40e_adminq.c >> index 221c327d1..bc9ef3c87 100644 >> --- a/drivers/net/i40e/base/i40e_adminq.c >> +++ b/drivers/net/i40e/base/i40e_adminq.c >> @@ -673,6 +673,9 @@ enum i40e_status_code i40e_init_adminq(struct >> i40e_hw *hw) >> if (ret_code != I40E_SUCCESS) >> goto init_adminq_free_asq; >> >> + if (i40e_is_vf(hw)) >> + goto init_adminq_exit; >> + >> /* There are some cases where the firmware may not be quite ready >> * for AdminQ operations, so we retry the AdminQ setup a few times >> * if we see timeouts in this first AQ call. >> -- >> 2.17.1 > >Acked-by: Beilei Xing Applied to dpdk-next-net-intel, Thanks.