DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/i40e/base: skip further adminq init for VF
@ 2020-01-22  3:58 Xiaolong Ye
  2020-01-22  4:48 ` Xing, Beilei
  0 siblings, 1 reply; 4+ messages in thread
From: Xiaolong Ye @ 2020-01-22  3:58 UTC (permalink / raw)
  To: Beilei Xing, Qi Zhang; +Cc: dev, Xiaolong Ye

Since VF has no need of firmware, we can skip further adminq init which
involves firmware operation, this patch fixes the testpmd segfault issue
when starting with i40e VF.

Fixes: d5e1a149362e ("net/i40e/base: check MAC type")

Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
---
 drivers/net/i40e/base/i40e_adminq.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/i40e/base/i40e_adminq.c b/drivers/net/i40e/base/i40e_adminq.c
index 221c327d1..bc9ef3c87 100644
--- a/drivers/net/i40e/base/i40e_adminq.c
+++ b/drivers/net/i40e/base/i40e_adminq.c
@@ -673,6 +673,9 @@ enum i40e_status_code i40e_init_adminq(struct i40e_hw *hw)
 	if (ret_code != I40E_SUCCESS)
 		goto init_adminq_free_asq;
 
+	if (i40e_is_vf(hw))
+		goto init_adminq_exit;
+
 	/* There are some cases where the firmware may not be quite ready
 	 * for AdminQ operations, so we retry the AdminQ setup a few times
 	 * if we see timeouts in this first AQ call.
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-01-23  9:07 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-22  3:58 [dpdk-dev] [PATCH] net/i40e/base: skip further adminq init for VF Xiaolong Ye
2020-01-22  4:48 ` Xing, Beilei
2020-01-22  7:49   ` Ye Xiaolong
2020-01-23  9:07     ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).