[dpdk-dev] [PATCH 0/2] net/bnxt: statistic related fixes

[dpdk-dev] [PATCH 0/2] net/bnxt: statistic related fixes

[Stephen Hemminger]

A couple of minor things in bnxt statistics

Stephen Hemminger (2):
  net/bnxt: do not print error if stats queried before start
  net/bnxt: remove unnecessary memset

 drivers/net/bnxt/bnxt_stats.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

-- 
2.20.1

[dpdk-dev] [PATCH 1/2] net/bnxt: do not print error if stats queried before start

[Stephen Hemminger]

When using pktgen lots of unnecessary errors are printed
because pktgen queries statistics before device is started.

Fixes: 3e92fd4e4ec0 ("net/bnxt: use dynamic log type")
Cc: ajit.khaparde@broadcom.com
Cc: stable@dpdk.org
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/bnxt/bnxt_stats.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c
index 20a16a629fb5..65f90e0d8588 100644
--- a/drivers/net/bnxt/bnxt_stats.c
+++ b/drivers/net/bnxt/bnxt_stats.c
@@ -390,10 +390,8 @@ int bnxt_stats_get_op(struct rte_eth_dev *eth_dev,
 		return rc;
 
 	memset(bnxt_stats, 0, sizeof(*bnxt_stats));
-	if (!(bp->flags & BNXT_FLAG_INIT_DONE)) {
-		PMD_DRV_LOG(ERR, "Device Initialization not complete!\n");
+	if (!(bp->flags & BNXT_FLAG_INIT_DONE))
 		return -EIO;
-	}
 
 	num_q_stats = RTE_MIN(bp->rx_cp_nr_rings,
 			      (unsigned int)RTE_ETHDEV_QUEUE_STAT_CNTRS);
-- 
2.20.1

[dpdk-dev] [PATCH 2/2] net/bnxt: remove unnecessary memset

[Stephen Hemminger]

The rte_ethdev layer already zeros statistics before calling
the device.

Fixes: 57d5e5bc86e4 ("net/bnxt: add statistics")
Cc: ajit.khaparde@broadcom.com
Cc: stable@dpdk.org
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/bnxt/bnxt_stats.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c
index 65f90e0d8588..32f112b5ba35 100644
--- a/drivers/net/bnxt/bnxt_stats.c
+++ b/drivers/net/bnxt/bnxt_stats.c
@@ -389,7 +389,6 @@ int bnxt_stats_get_op(struct rte_eth_dev *eth_dev,
 	if (rc)
 		return rc;
 
-	memset(bnxt_stats, 0, sizeof(*bnxt_stats));
 	if (!(bp->flags & BNXT_FLAG_INIT_DONE))
 		return -EIO;
 
-- 
2.20.1

Re: [dpdk-dev] [PATCH 0/2] net/bnxt: statistic related fixes

[Ajit Khaparde]

On Wed, Jan 22, 2020 at 9:56 AM Stephen Hemminger <
stephen@networkplumber.org> wrote:

> A couple of minor things in bnxt statistics
>
> Stephen Hemminger (2):
>   net/bnxt: do not print error if stats queried before start
>   net/bnxt: remove unnecessary memset
>
>  drivers/net/bnxt/bnxt_stats.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> Patches applied to dpdk-next-net-brcm. Thanks


> --
> 2.20.1
>
>

Re: [dpdk-dev] [PATCH 0/2] net/bnxt: statistic related fixes

[Ferruh Yigit]

On 1/22/2020 11:37 PM, Ajit Khaparde wrote:
> On Wed, Jan 22, 2020 at 9:56 AM Stephen Hemminger <
> stephen@networkplumber.org> wrote:
> 
>> A couple of minor things in bnxt statistics
>>
>> Stephen Hemminger (2):
>>   net/bnxt: do not print error if stats queried before start
>>   net/bnxt: remove unnecessary memset
>>
>>  drivers/net/bnxt/bnxt_stats.c | 5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> Patches applied to dpdk-next-net-brcm. Thanks
> 

Hi Ajit,

It seems they are not pushed into your tree. Please ping me when you do, I can
pull afterwards.