From: Ye Xiaolong <xiaolong.ye@intel.com>
To: David Harton <dharton@cisco.com>
Cc: dev@dpdk.org, wenzhuo.lu@intel.com
Subject: Re: [dpdk-dev] [PATCH] net/e1000: update UPDATE_VF_STAT to handle rollover
Date: Sun, 26 Jan 2020 17:41:43 +0800 [thread overview]
Message-ID: <20200126094143.GA54838@intel.com> (raw)
In-Reply-To: <20191211024802.17978-1-dharton@cisco.com>
On 12/10, David Harton wrote:
>Modified UPDATE_VF_STAT to properly handle rollover conditions.
>
>Signed-off-by: David Harton <dharton@cisco.com>
>---
> drivers/net/e1000/igb_ethdev.c | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
>index a3e30dbe5..825663267 100644
>--- a/drivers/net/e1000/igb_ethdev.c
>+++ b/drivers/net/e1000/igb_ethdev.c
>@@ -261,11 +261,15 @@ static int igb_filter_restore(struct rte_eth_dev *dev);
> /*
> * Define VF Stats MACRO for Non "cleared on read" register
> */
>-#define UPDATE_VF_STAT(reg, last, cur) \
>-{ \
>- u32 latest = E1000_READ_REG(hw, reg); \
>- cur += (latest - last) & UINT_MAX; \
>- last = latest; \
>+#define UPDATE_VF_STAT(reg, last, cur) \
>+{ \
>+ u32 latest = E1000_READ_REG(hw, reg); \
>+ if (latest >= last) \
>+ cur += (latest - last); \
>+ else \
>+ cur += ((latest + ((uint64_t)1 << 32)) - last); \
>+ cur &= UINT_MAX; \
>+ last = latest; \
> }
>
> #define IGB_FC_PAUSE_TIME 0x0680
>--
>2.19.1
>
Could you provide Fixes: tag and cc stable?
Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>
next prev parent reply other threads:[~2020-01-26 9:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 2:48 David Harton
2020-01-26 9:41 ` Ye Xiaolong [this message]
2020-01-26 17:25 ` [dpdk-dev] [PATCH v2] " David Harton
2020-01-29 7:53 ` Ye Xiaolong
2020-01-29 10:10 ` Ferruh Yigit
2020-01-29 17:56 ` David Harton (dharton)
2020-01-31 8:46 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200126094143.GA54838@intel.com \
--to=xiaolong.ye@intel.com \
--cc=dev@dpdk.org \
--cc=dharton@cisco.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).