From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EBE39A0524; Thu, 30 Jan 2020 10:25:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2ABE71BFE6; Thu, 30 Jan 2020 10:25:38 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 6B5E11BFE5 for ; Thu, 30 Jan 2020 10:25:36 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 00U9Gr4B002976; Thu, 30 Jan 2020 01:25:34 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0818; bh=j0uh9PfToThwdAYSM0DyN8AIxYx+O2F6ls96+QProqg=; b=DkNBbANgzeuJnXMAOadsBIMv2kmyWZmCh6LLnffh88nLgcj93JAefcW1zPNUDWGsq6zW She9QNNby8CJVKqAOs82/69CuTGrQgTLs9c+01J1EzZo0vKw0pBs8Jkwskfi/BujvIFv eErT9qXJQxWIu3Y9tKaaDfIQ9H4RzHh2R9hNUUnlYTpDVXYwYrmvB0LLwtq3sfsVCpbS C2FndxEyKsFBGE2byFNwjZ64T6fFNGbVrYehB4B4htZtZyRt38xktbSp58YJfd1ndI09 eP63xD5c4Gds3lBon40sdT1QiEbW0Pv9gV3dOVkTY4HV8sYiwgjeXJCJKOLqqm/ry7U2 2Q== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 2xupkhsa5r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 30 Jan 2020 01:25:34 -0800 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 30 Jan 2020 01:25:33 -0800 Received: from maili.marvell.com (10.93.176.43) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 30 Jan 2020 01:25:33 -0800 Received: from amok.marvell.com (unknown [10.95.130.49]) by maili.marvell.com (Postfix) with ESMTP id 8CC103F7040; Thu, 30 Jan 2020 01:25:31 -0800 (PST) From: Andrzej Ostruszka To: , David Hunt , Bruce Richardson , Vladimir Medvedkin , Robert Sanford , Erik Gabriel Carrillo CC: Date: Thu, 30 Jan 2020 10:25:30 +0100 Message-ID: <20200130092530.27907-1-aostruszka@marvell.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200129162347.27975-1-aostruszka@marvell.com> References: <20200129162347.27975-1-aostruszka@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-01-30_02:2020-01-28, 2020-01-30 signatures=0 Subject: [dpdk-dev] [PATCH v2] build: remove unused function versioning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Timer, LPM and Distributor libraries no longer use function versioning and therefore do not need separate build for static and shared version of libraries. This patch removes use_function_versioning from their meson build files and corresponding include from the sources. Signed-off-by: Andrzej Ostruszka Acked-by: Bruce Richardson Fixes: f2fb215843a9 ("timer: remove deprecated code") Fixes: 6e5b51676176 ("distributor: remove deprecated code") Fixes: c381a8d554b7 ("lpm: remove deprecated code") Cc: marcinx.baran@intel.com --- V2: - removed also includes (updating only meson files causes build failures), and updated commit msg accordingly --- lib/librte_distributor/meson.build | 1 - lib/librte_distributor/rte_distributor.c | 1 - lib/librte_distributor/rte_distributor_single.c | 1 - lib/librte_lpm/meson.build | 1 - lib/librte_lpm/rte_lpm.c | 1 - lib/librte_lpm/rte_lpm6.c | 1 - lib/librte_timer/meson.build | 1 - lib/librte_timer/rte_timer.c | 1 - 8 files changed, 8 deletions(-) diff --git a/lib/librte_distributor/meson.build b/lib/librte_distributor/meson.build index 50b91887b..266af6434 100644 --- a/lib/librte_distributor/meson.build +++ b/lib/librte_distributor/meson.build @@ -9,7 +9,6 @@ else endif headers = files('rte_distributor.h') deps += ['mbuf'] -use_function_versioning = true # for clang 32-bit compiles we need libatomic for 64-bit atomic ops if cc.get_id() == 'clang' and dpdk_conf.get('RTE_ARCH_64') == false diff --git a/lib/librte_distributor/rte_distributor.c b/lib/librte_distributor/rte_distributor.c index 6c5b0c86e..1c047f065 100644 --- a/lib/librte_distributor/rte_distributor.c +++ b/lib/librte_distributor/rte_distributor.c @@ -8,7 +8,6 @@ #include #include #include -#include #include #include #include diff --git a/lib/librte_distributor/rte_distributor_single.c b/lib/librte_distributor/rte_distributor_single.c index 91d8824c6..abaf7730c 100644 --- a/lib/librte_distributor/rte_distributor_single.c +++ b/lib/librte_distributor/rte_distributor_single.c @@ -9,7 +9,6 @@ #include #include #include -#include #include #include #include diff --git a/lib/librte_lpm/meson.build b/lib/librte_lpm/meson.build index 27ce45b53..021ac6d8d 100644 --- a/lib/librte_lpm/meson.build +++ b/lib/librte_lpm/meson.build @@ -7,4 +7,3 @@ headers = files('rte_lpm.h', 'rte_lpm6.h') # without worrying about which architecture we actually need headers += files('rte_lpm_altivec.h', 'rte_lpm_neon.h', 'rte_lpm_sse.h') deps += ['hash'] -use_function_versioning = true diff --git a/lib/librte_lpm/rte_lpm.c b/lib/librte_lpm/rte_lpm.c index b78c48744..268756419 100644 --- a/lib/librte_lpm/rte_lpm.c +++ b/lib/librte_lpm/rte_lpm.c @@ -22,7 +22,6 @@ #include #include #include -#include #include "rte_lpm.h" diff --git a/lib/librte_lpm/rte_lpm6.c b/lib/librte_lpm/rte_lpm6.c index c46e557e2..b981e4071 100644 --- a/lib/librte_lpm/rte_lpm6.c +++ b/lib/librte_lpm/rte_lpm6.c @@ -25,7 +25,6 @@ #include #include #include -#include #include "rte_lpm6.h" diff --git a/lib/librte_timer/meson.build b/lib/librte_timer/meson.build index b7edfe2e7..d3b828ce9 100644 --- a/lib/librte_timer/meson.build +++ b/lib/librte_timer/meson.build @@ -4,4 +4,3 @@ sources = files('rte_timer.c') headers = files('rte_timer.h') allow_experimental_apis = true -use_function_versioning = true diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c index a1ed186cf..89f27074f 100644 --- a/lib/librte_timer/rte_timer.c +++ b/lib/librte_timer/rte_timer.c @@ -26,7 +26,6 @@ #include #include #include -#include #include "rte_timer.h" -- 2.17.1