* [dpdk-dev] [PATCH] net/bnxt: fix to remove spurious warning in Rx handler
@ 2020-01-31 5:12 Somnath Kotur
0 siblings, 0 replies; 3+ messages in thread
From: Somnath Kotur @ 2020-01-31 5:12 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit
HW seems to populate the cfa code in the Rx descriptor even
if an explicit flow rule is not configured via application as
there might be a default rule configured in HW even for promisc
mode.
Fixes: 6d9be25b9771 ("net/bnxt: fix to support zero mark id along with RSS action")
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
---
drivers/net/bnxt/bnxt_rxr.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
index 1960b05..1f47db9 100644
--- a/drivers/net/bnxt/bnxt_rxr.c
+++ b/drivers/net/bnxt/bnxt_rxr.c
@@ -909,11 +909,8 @@ void bnxt_set_mark_in_mbuf(struct bnxt *bp,
if (!cfa_code)
return;
- if (cfa_code && !bp->mark_table[cfa_code].valid) {
- PMD_DRV_LOG(WARNING, "Invalid mark_tbl entry! cfa_code: 0x%x\n",
- cfa_code);
+ if (cfa_code && !bp->mark_table[cfa_code].valid)
return;
- }
flags2 = rte_le_to_cpu_16(rxcmp1->flags2);
meta = rte_le_to_cpu_32(rxcmp1->metadata);
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/bnxt: fix to remove spurious warning in Rx handler
2020-01-31 5:05 Somnath Kotur
@ 2020-01-31 5:09 ` Somnath Kotur
0 siblings, 0 replies; 3+ messages in thread
From: Somnath Kotur @ 2020-01-31 5:09 UTC (permalink / raw)
To: dev; +Cc: Ferruh Yigit
Please ignore this patch
Thanks
On Fri, Jan 31, 2020 at 10:37 AM Somnath Kotur <somnath.kotur@broadcom.com>
wrote:
> HW seems to populate the cfa code in the Rx descriptor even
> if an explicit flow rule is not configured via application as
> there might be a default rule configured in HW even for promisc
> mode.
>
> Fixes: ff88f133be45 ("net/bnxt: fix to support zero mark id along with RSS
> action")
>
> Bug: CTRL-45914
> Change-Id: I1c1a95b0a4661fd7b8bbe02de62d18e0119d15d2
> Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
> ---
> drivers/net/bnxt/bnxt_rxr.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
> index 1960b05..1f47db9 100644
> --- a/drivers/net/bnxt/bnxt_rxr.c
> +++ b/drivers/net/bnxt/bnxt_rxr.c
> @@ -909,11 +909,8 @@ void bnxt_set_mark_in_mbuf(struct bnxt *bp,
> if (!cfa_code)
> return;
>
> - if (cfa_code && !bp->mark_table[cfa_code].valid) {
> - PMD_DRV_LOG(WARNING, "Invalid mark_tbl entry! cfa_code:
> 0x%x\n",
> - cfa_code);
> + if (cfa_code && !bp->mark_table[cfa_code].valid)
> return;
> - }
>
> flags2 = rte_le_to_cpu_16(rxcmp1->flags2);
> meta = rte_le_to_cpu_32(rxcmp1->metadata);
> --
> 1.8.3.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [dpdk-dev] [PATCH] net/bnxt: fix to remove spurious warning in Rx handler
@ 2020-01-31 5:05 Somnath Kotur
2020-01-31 5:09 ` Somnath Kotur
0 siblings, 1 reply; 3+ messages in thread
From: Somnath Kotur @ 2020-01-31 5:05 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit
HW seems to populate the cfa code in the Rx descriptor even
if an explicit flow rule is not configured via application as
there might be a default rule configured in HW even for promisc
mode.
Fixes: ff88f133be45 ("net/bnxt: fix to support zero mark id along with RSS action")
Bug: CTRL-45914
Change-Id: I1c1a95b0a4661fd7b8bbe02de62d18e0119d15d2
Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
---
drivers/net/bnxt/bnxt_rxr.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
index 1960b05..1f47db9 100644
--- a/drivers/net/bnxt/bnxt_rxr.c
+++ b/drivers/net/bnxt/bnxt_rxr.c
@@ -909,11 +909,8 @@ void bnxt_set_mark_in_mbuf(struct bnxt *bp,
if (!cfa_code)
return;
- if (cfa_code && !bp->mark_table[cfa_code].valid) {
- PMD_DRV_LOG(WARNING, "Invalid mark_tbl entry! cfa_code: 0x%x\n",
- cfa_code);
+ if (cfa_code && !bp->mark_table[cfa_code].valid)
return;
- }
flags2 = rte_le_to_cpu_16(rxcmp1->flags2);
meta = rte_le_to_cpu_32(rxcmp1->metadata);
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-31 5:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-31 5:12 [dpdk-dev] [PATCH] net/bnxt: fix to remove spurious warning in Rx handler Somnath Kotur
-- strict thread matches above, loose matches on Subject: below --
2020-01-31 5:05 Somnath Kotur
2020-01-31 5:09 ` Somnath Kotur
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).