Re: [dpdk-dev] [PATCH v6 03/10] eal: include filesystem implementation for windows

[Dmitry Kozliuk <dmitry.kozliuk@gmail.com>]

Hello Pallavi,

> +#include "eal_internal_cfg.h"
> +
> +/* sets up platform-specific runtime data dir */
> +int
> +eal_create_runtime_dir(void);
> +
> +/* returns runtime dir */
> +const char *
> +eal_get_runtime_dir(void);

Any reason not to #include "eal_filesystem.h"?

> +
> +static inline const char *
> +eal_runtime_config_path(void)
> +{
> +	static char buffer[PATH_MAX];  /* static so auto-zeroed */
> +	char  Directory[PATH_MAX];

Should be "directory" according to the style guide.

> +
> +	GetTempPathA(sizeof(Directory), Directory);
> +	snprintf(buffer, sizeof(buffer)-1, RUNTIME_CONFIG_FMT, Directory,

Style guide requires spaces around binary "-".

> +static inline const char *
> +eal_hugepage_info_path(void)
> +{
> +	static char buffer[PATH_MAX];  /* static so auto-zeroed */
> +	TCHAR  Directory[PATH_MAX];

Should be "directory", see above.