From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D00B1A0524; Fri, 31 Jan 2020 07:04:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 471801C044; Fri, 31 Jan 2020 07:04:36 +0100 (CET) Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by dpdk.org (Postfix) with ESMTP id 970F31C030 for ; Fri, 31 Jan 2020 07:04:35 +0100 (CET) Received: by mail-lj1-f196.google.com with SMTP id x7so5918248ljc.1 for ; Thu, 30 Jan 2020 22:04:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=hnArTbHyLhmNk22QqzT5eBJsCCTKulfi94mCznMFF/k=; b=eHLhqRQ+YA0+ABKMpXwT8RR/L6sNOXRds0edxmY9cD3Ey2BuJ5I+B6H8QRqYUj0a/w +5i3uZXgqyavJyZygEs56g+Zi8c9DPGg5gRmkzLIZw8sKZKdnvNbwtp2C5Wzdjg8LBeQ kllGQsfbCl49P308Gq4K0jlIWOGG2OzBykgY/1DKcbjPD72t8wTup4KjYoXsaYhsNypQ CbCTM1J294dk6IrG0Ii+/ZbqXvhwUqU99Z31LekT1UmsCE9DLf/RgxkhOg/mi+Rh6124 uCH5fc0u+/oVkwQe8kyiBYFXGku6Q2niazJDpUjNMwKWW88vS8snk5VmreOS3dFIttzn QNcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hnArTbHyLhmNk22QqzT5eBJsCCTKulfi94mCznMFF/k=; b=Ww4eq8jEvZJSNAj++D/7KRmuxYf8ieHHu5HvXK24bECsVWgrxU/yJndp4QtRVXKUE7 YNWVCQt1HAOHCQ+Gr8yQVvWtR3xT1vZylYMy4wuYMCM53lKLSreyYJqwxjNgH+EIMLzF 0rKPLBoQ0P7WB1sgw6RH38OGL6ohRXP2km3RdM7gR0d4kiYiSt2LVm40F5MuUeROFBGO KRx2zyRrnnFJnsjpUxZojED2xf6xHx7sGHz29VXyjgRDiMr8Azz8v+x8KQ/sYfnTgOgq gDofFasFMQgblEZtdQc3D1rD+9UYbEx5td8kHvPDzMRXlNBwEJwvwjkrlFA16/D1Vdmi VSMg== X-Gm-Message-State: APjAAAWbeIRf5pW2PO/VB6PYTtEJUpg1i3XCla88WkQJO1c3e1gd0DtR SZyQRGMwvnKhYsX51uCLpC43zY4EmeWtFA== X-Google-Smtp-Source: APXvYqxR8dJ5faJpJBKIDNKL4wcVxg9MEOuVR2nv4iIya9fCh57H1pNUOa5tvUYCICdKI4Y1aK18ww== X-Received: by 2002:a2e:99c5:: with SMTP id l5mr4742335ljj.88.1580450674817; Thu, 30 Jan 2020 22:04:34 -0800 (PST) Received: from Sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id z3sm4119548ljh.83.2020.01.30.22.04.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jan 2020 22:04:34 -0800 (PST) Date: Fri, 31 Jan 2020 09:04:33 +0300 From: Dmitry Kozliuk To: dev@dpdk.org Message-ID: <20200131090433.1aa037ff@Sovereign> In-Reply-To: <20200131000307.10608-4-pallavi.kadam@intel.com> References: <20200113215534.10084-1-pallavi.kadam@intel.com> <20200131000307.10608-1-pallavi.kadam@intel.com> <20200131000307.10608-4-pallavi.kadam@intel.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 03/10] eal: include filesystem implementation for windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Pallavi, > +#include "eal_internal_cfg.h" > + > +/* sets up platform-specific runtime data dir */ > +int > +eal_create_runtime_dir(void); > + > +/* returns runtime dir */ > +const char * > +eal_get_runtime_dir(void); Any reason not to #include "eal_filesystem.h"? > + > +static inline const char * > +eal_runtime_config_path(void) > +{ > + static char buffer[PATH_MAX]; /* static so auto-zeroed */ > + char Directory[PATH_MAX]; Should be "directory" according to the style guide. > + > + GetTempPathA(sizeof(Directory), Directory); > + snprintf(buffer, sizeof(buffer)-1, RUNTIME_CONFIG_FMT, Directory, Style guide requires spaces around binary "-". > +static inline const char * > +eal_hugepage_info_path(void) > +{ > + static char buffer[PATH_MAX]; /* static so auto-zeroed */ > + TCHAR Directory[PATH_MAX]; Should be "directory", see above.