From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 01DF3A04FA;
	Sun,  2 Feb 2020 11:35:29 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id D1EC41BF95;
	Sun,  2 Feb 2020 11:35:28 +0100 (CET)
Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com
 [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id C83B71BEE5
 for <dev@dpdk.org>; Sun,  2 Feb 2020 11:35:27 +0100 (CET)
Received: by mail-wr1-f68.google.com with SMTP id z3so14223679wru.3
 for <dev@dpdk.org>; Sun, 02 Feb 2020 02:35:27 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=b0Gek4yaIIwA4bW5q1+HSgdi0CQBtjCtfe7I5W1/Nxw=;
 b=0gPoJgiKKcgXUju2Oy429YpScl/B7HsY404uC6vLcXsbnospgoht0rfytiOPpX9Gvs
 jHpEkoKUTiNeaCFomt8dYQBqheYcrN+zHp7/1CgL2RoBOa416jwr0I5bzhWP2WtfIzwe
 899x2BfUx4k2+H8c3dQcTAUvTHtulkJS8Cy1BrQdPhR6nYXASo7hwwQ/CjG9yL2+RD2N
 qNnDZNDrGcF5WJsTRxBE4HUZm4uKqESEhmMKrfTERvHsDCKdink1BmknbFIvIGsSyF36
 uqwqIngJLBUswNnuVfqRdDwgToCja/TeoAWAAyq0JVm/aobk6C1z640x2zuaHKoYzJH7
 oGww==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=b0Gek4yaIIwA4bW5q1+HSgdi0CQBtjCtfe7I5W1/Nxw=;
 b=pE0RYi47Vgu7t5Ouy8RsgK+3VeYH4nDdE1ikCxRPMOLwJg3DuFdmfjNwftk3JhwhYn
 c3hvPCbeInPMfZ363FTyB+6yezdGF+it+RO4jGOxAHZB3ipYptKDjpABiM+YGijRv3GL
 ezRb6wHkFBJJ3NznOiusFDhpqE630j9OoXD1W8WiVJ8QfunbILGsy8um3zhlsHorZdKY
 CJ11bZsWLZYIi4PZuG6anfsSiv8RyrHBl2bnrS+sU3aKsHoejLyvYj6M49ka703F266b
 nPc9IbPQyQnpWeX1+kTQ58ImnAvtR9NpUt2jguJWV7u0mUfcyDvcTRszVjQih9x1IjwY
 aNYQ==
X-Gm-Message-State: APjAAAW6bpZlAJbu5UjoonvuazI3LCoiNllRlbHUC/Ic0MDn40N+LfYU
 +jbG+RJy7o3EYNgeovfR43pCYw==
X-Google-Smtp-Source: APXvYqy+j9q9u/VTwVMlH1A9b8aFh0Pf7ow3zOUuO3p72I+m+YrC8ySf2itifQ7UzHtGA9Sncomimw==
X-Received: by 2002:a5d:4052:: with SMTP id w18mr3724565wrp.112.1580639727595; 
 Sun, 02 Feb 2020 02:35:27 -0800 (PST)
Received: from shemminger-XPS-13-9360
 ([2001:67c:1810:f051:c492:1a1f:b276:cd6e])
 by smtp.gmail.com with ESMTPSA id z8sm20131236wrq.22.2020.02.02.02.35.24
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 02 Feb 2020 02:35:27 -0800 (PST)
Date: Sun, 2 Feb 2020 02:35:23 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: <jerinj@marvell.com>
Cc: <dev@dpdk.org>, <pkapoor@marvell.com>, <ndabilpuram@marvell.com>,
 <kirankumark@marvell.com>, <pbhagavatula@marvell.com>,
 <pathreya@marvell.com>, <nsaxena@marvell.com>, <sshankarnara@marvell.com>,
 <honnappa.nagarahalli@arm.com>, <thomas@monjalon.net>,
 <david.marchand@redhat.com>, <ferruh.yigit@intel.com>,
 <arybchenko@solarflare.com>, <ajit.khaparde@broadcom.com>,
 <xiaolong.ye@intel.com>, <rasland@mellanox.com>,
 <maxime.coquelin@redhat.com>, <akhil.goyal@nxp.com>,
 <cristian.dumitrescu@intel.com>, <john.mcnamara@intel.com>,
 <bruce.richardson@intel.com>, <anatoly.burakov@intel.com>,
 <gavin.hu@arm.com>, <drc@linux.vnet.ibm.com>,
 <konstantin.ananyev@intel.com>, <pallavi.kadam@intel.com>,
 <olivier.matz@6wind.com>, <gage.eads@intel.com>, <nikhil.rao@intel.com>,
 <erik.g.carrillo@intel.com>, <hemant.agrawal@nxp.com>,
 <artem.andreev@oktetlabs.ru>, <sthemmin@microsoft.com>,
 <shahafs@mellanox.com>, <keith.wiles@intel.com>,
 <mattias.ronnblom@ericsson.com>, <jasvinder.singh@intel.com>,
 <vladimir.medvedkin@intel.com>, <mdr@ashroe.eu>, <techboard@dpdk.org>
Message-ID: <20200202023523.2f160b4e@shemminger-XPS-13-9360>
In-Reply-To: <20200131170201.3236153-2-jerinj@marvell.com>
References: <20200131170201.3236153-1-jerinj@marvell.com>
 <20200131170201.3236153-2-jerinj@marvell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [RFC PATCH 1/5] graph: introduce graph subsystem
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 31 Jan 2020 22:31:57 +0530
<jerinj@marvell.com> wrote:

> +	/* Create graph object */
> +	graph = calloc(1, sizeof(*graph));
> +	if (graph == NULL)
> +		set_err(ENOMEM, fail, "failed to calloc graph object");

This won't be safe if used in primary/secondary process model.
You would need to use rte_calloc etc to allow this.