From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD365A04FA; Sun, 2 Feb 2020 07:56:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1750E1BFFC; Sun, 2 Feb 2020 07:56:23 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id D48C71BFF7 for ; Sun, 2 Feb 2020 07:56:21 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Feb 2020 22:56:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,393,1574150400"; d="scan'208";a="223592389" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga008.jf.intel.com with ESMTP; 01 Feb 2020 22:56:19 -0800 Date: Sun, 2 Feb 2020 14:55:26 +0800 From: Ye Xiaolong To: Yunjian Wang Cc: dev@dpdk.org, wenzhuo.lu@intel.com, xudingke@huawei.com Message-ID: <20200202065526.GH54838@intel.com> References: <1578918028-23280-1-git-send-email-wangyunjian@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1578918028-23280-1-git-send-email-wangyunjian@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/e1000: use macro PCI_PRI_FMT for PCI log format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 01/13, Yunjian Wang wrote: >Use PCI_PRI_FMT instead of "%04d:%02d:%02d:%d" print format. > >Signed-off-by: Yunjian Wang >--- > drivers/net/e1000/em_ethdev.c | 2 +- > drivers/net/e1000/igb_ethdev.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c >index 080cbe2df..188cda350 100644 >--- a/drivers/net/e1000/em_ethdev.c >+++ b/drivers/net/e1000/em_ethdev.c >@@ -1605,7 +1605,7 @@ eth_em_interrupt_action(struct rte_eth_dev *dev, > } else { > PMD_INIT_LOG(INFO, " Port %d: Link Down", dev->data->port_id); > } >- PMD_INIT_LOG(DEBUG, "PCI Address: %04d:%02d:%02d:%d", >+ PMD_INIT_LOG(DEBUG, "PCI Address: " PCI_PRI_FMT, > pci_dev->addr.domain, pci_dev->addr.bus, > pci_dev->addr.devid, pci_dev->addr.function); > >diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c >index a3e30dbe5..30e303c9b 100644 >--- a/drivers/net/e1000/igb_ethdev.c >+++ b/drivers/net/e1000/igb_ethdev.c >@@ -2914,7 +2914,7 @@ eth_igb_interrupt_action(struct rte_eth_dev *dev, > dev->data->port_id); > } > >- PMD_INIT_LOG(DEBUG, "PCI Address: %04d:%02d:%02d:%d", >+ PMD_INIT_LOG(DEBUG, "PCI Address: " PCI_PRI_FMT, > pci_dev->addr.domain, > pci_dev->addr.bus, > pci_dev->addr.devid, >-- >2.19.1 > > Acked-by: Xiaolong Ye Applied to dpdk-next-net-intel, Thanks.