From: Stephen Hemminger <stephen@networkplumber.org>
To: Matan Azrad <matan@mellanox.com>
Cc: Viacheslav Ovsiienko <viacheslavo@mellanox.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] common/mlx5: redefine Netlink include
Date: Tue, 4 Feb 2020 00:59:34 -0800 [thread overview]
Message-ID: <20200204005934.07fe2468@shemminger-XPS-13-9360> (raw)
In-Reply-To: <1580659153-25436-1-git-send-email-matan@mellanox.com>
On Sun, 2 Feb 2020 15:59:13 +0000
Matan Azrad <matan@mellanox.com> wrote:
> The new RDMA-CORE versions may have the same sub-path to include the
> linux Netlink header file.
>
> It uses the pre-proccessor command #include_next what breaks the PMD gcc
> compilation of common/mlx5_netlink.h file in debug mode.
>
> Use specific include for linux/netlink.h to be taken from
> /usr/include/linux.
>
> Signed-off-by: Matan Azrad <matan@mellanox.com>
> ---
> drivers/common/mlx5/mlx5_nl.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/common/mlx5/mlx5_nl.h b/drivers/common/mlx5/mlx5_nl.h
> index 2c3f837..ebaa655 100644
> --- a/drivers/common/mlx5/mlx5_nl.h
> +++ b/drivers/common/mlx5/mlx5_nl.h
> @@ -5,7 +5,7 @@
> #ifndef RTE_PMD_MLX5_NL_H_
> #define RTE_PMD_MLX5_NL_H_
>
> -#include <linux/netlink.h>
> +#include "/usr/include/linux/netlink.h"
I think this should be fixed with CFLAGS, not hard coding path to netlink.h
Doing it this way is sure to break some cross build environments.
prev parent reply other threads:[~2020-02-04 8:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-02 15:59 Matan Azrad
2020-02-03 11:42 ` Slava Ovsiienko
2020-02-03 12:23 ` Raslan Darawsheh
2020-02-03 14:24 ` Ferruh Yigit
2020-02-03 15:02 ` Matan Azrad
2020-02-03 16:51 ` Ferruh Yigit
2020-02-03 17:08 ` Matan Azrad
2020-02-04 8:59 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200204005934.07fe2468@shemminger-XPS-13-9360 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).