From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0024A04FA; Wed, 5 Feb 2020 18:14:28 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 79FB61C2F6; Wed, 5 Feb 2020 18:14:28 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id EA89C1C2F4 for ; Wed, 5 Feb 2020 18:14:26 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Feb 2020 09:14:26 -0800 X-IronPort-AV: E=Sophos;i="5.70,406,1574150400"; d="scan'208";a="224720467" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.79]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 05 Feb 2020 09:14:25 -0800 Date: Wed, 5 Feb 2020 17:14:22 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org Message-ID: <20200205171422.GB759@bricha3-MOBL.ger.corp.intel.com> References: <20200205170723.3347232-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200205170723.3347232-1-thomas@monjalon.net> User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH] buildtools: allow pedantic empty pmdinfo X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Feb 05, 2020 at 06:07:23PM +0100, Thomas Monjalon wrote: > If a driver has no info generated by pmdinfogen, > and if this driver is compiled as pedantic, > then an failure would occur: > drivers/rte_common_mlx5.pmd.c:1: error: > ISO C forbids an empty translation unit [-Werror=pedantic] > Such error is triggered with the new mlx5 common directory. > > In order to allow an "empty driver info" compiled in pedantic mode, > the script generating .pmd.c file is modified to add a static string > unconditionnaly. > The minimal generated code is: > static __attribute__((unused)) const char *generator = > "/path/to/dpdk/buildtools/gen-pmdinfo-cfile.sh"; > > Signed-off-by: Thomas Monjalon LGTM Acked-by: Bruce Richardson